Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Experimental 4:3 Aspect Ratio" option #105

Merged
merged 3 commits into from
Jan 24, 2023
Merged

Add "Experimental 4:3 Aspect Ratio" option #105

merged 3 commits into from
Jan 24, 2023

Conversation

drojf
Copy link
Contributor

@drojf drojf commented Jan 19, 2023

This adds an option which runs the game in 4:3 resolution for use on monitors with 4:3 resolution (or less than 16:9 aspect)

TODO

Warped Spiral Mask

  • One episodes 5 and up, Sprial fade and other effects are squished more than they should be - these may be better cropped or use the original 4:3 version (but probably can't replace the file directly as non-4:3 OG mode uses these files as well?)

After some investigation:
for the question arcs (or at least episode 1), we have stretched all the masks, so the normal mod spiral mask looks like this:

image

But for the answer arcs, the same spiral mask is cropped, and looks like this:

image

So the engine actually behaves the same, it's just the actual mask image is different

so for question arcs it works out because the image is stretched and then un-stretched, but for the answer arcs it doesn't work

because it is is cropped and then un-stretched

Here is the unmodded game's spiral:
image

this does mean our normal modded game is warped for the question arcs, and furthermore it's not consistent between question and answer arcs


Here is a pack containing all the OG masks (some are created from modded masks if no OG exists):

og-mask-pack.zip

ADV textbox arrow cut off:

  • ADV textbox arrow cut off:
    image

Squashed Commits:

  • Reset 4:3 mode when choosing a preset
  • Simplify conditions for 4:3 mode
  • Squish 16:9 images to 4:3 - any 16:9 images will be squished to fit in 4:3 so they don't get cut off - This fixes movie playback also
  • Don't clamp sprites if using true 4:3 mode
  • Do not stretch sprites in 4:3 mode
  • Make sure aspect is set before redraw to avoid temporary graphics artifacts
  • Automatically set Original textbox when 4:3 mode enabled
  • Update 4:3 mode hover description
  • Fix mod menu resolution buttons resetting aspect ratio
  • Fix mod menu at low 4:3 resolutions
  • Fix ADV mode textbox when using true 4:3 mode
  • Fix images drawn as bustshots not being resized
  • Fix mod menu button overlapping settings text
  • Fix choice text overflowing screen
  • Do not stretch odd aspect ratio images
  • Fix NVL mode and NVL-in-ADV mode 862b60eab63e1e9e2829f813c71a58d74475d5a0

drojf added 3 commits January 18, 2023 22:09
 - This adds an option which runs the game in 4:3 resolution for
   use on monitors with 4:3 resolution (or less than 16:9 aspect)

Squashed Commits:
- Reset 4:3 mode when choosing a preset
- Simplify conditions for 4:3 mode
- Squish 16:9 images to 4:3
    - any 16:9 images will be squished to fit in 4:3 so they don't get cut off
    - This fixes movie playback also
- Don't clamp sprites if using true 4:3 mode
- Do not stretch sprites in 4:3 mode
- Make sure aspect is set before redraw to avoid temporary graphics artifacts
- Automatically set Original textbox when 4:3 mode enabled
- Update 4:3 mode hover description
- Fix mod menu resolution buttons resetting aspect ratio
- Fix mod menu at low 4:3 resolutions
- Fix ADV mode textbox when using true 4:3 mode
- Fix images drawn as bustshots not being resized
- Fix mod menu button overlapping settings text
- Fix choice text overflowing screen
- Do not stretch odd aspect ratio images
- Fix NVL mode and NVL-in-ADV mode 862b60eab63e1e9e2829f813c71a58d74475d5a0
@drojf drojf marked this pull request as ready for review January 24, 2023 02:25
@drojf drojf merged commit e6b498e into mod Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant