Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change defaults from cosmos->celestia for codec testutil #4

Closed

Conversation

damiannolan
Copy link

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@damiannolan
Copy link
Author

see 01builders/celestia-app#13

@damiannolan
Copy link
Author

we can also just extend moduletestutil to add another API which lets you override this, then do it in celestia-app. either is fine imo

Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I disagree with this change. All tests in the SDK will fail because of that.

Cannot we just bring in the api we add in 0.52 that passes a custom config? But instead of breaking it, we do smth like FooWithBar

@julienrbrt
Copy link
Member

we can also just extend moduletestutil to add another API which lets you override this, then do it in celestia-app. either is fine imo

Yes please, otherwise we cannot trust the fork tests. Which is annoying.

@damiannolan
Copy link
Author

yeah sounds good. agree with that for sure! didn't notice the failing tests til you mentioned, definitely would prefer to bring the 52 api in

@damiannolan
Copy link
Author

closing in favour of other PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants