Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Add start time for continuous vesting accounts (#342) #3

Merged
merged 4 commits into from
Feb 12, 2025

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Feb 12, 2025

Cherry-pick celestiaorg#342.

Closes: CEL-22

* Draft changes to be able to add a start-time in the future for a continuous vesting acct

* Some minor cleanup for consistency

* chore: add a test to the cli

* chore: run make proto-gen using old scripts

* delete TestGetVestingCoinsContVestingAccStartTimeInFuture

* fix merge/rebase glitch

* make GetVested.. test consistent

* update spec

---------

Co-authored-by: evan-forbes <evan.samuel.forbes@gmail.com>
@julienrbrt julienrbrt marked this pull request as ready for review February 12, 2025 11:27
Copy link

@chatton chatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for pulling these out.

@julienrbrt julienrbrt merged commit 926f94b into release/v0.50.x-celestia Feb 12, 2025
50 of 52 checks passed
@julienrbrt julienrbrt deleted the julien/vesting branch February 12, 2025 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants