-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(*) update project to build kumactl at windows #2597
Merged
bartsmykla
merged 5 commits into
kumahq:master
from
bartsmykla:feat/prepare-kumactl-for-windows-compilation
Aug 19, 2021
Merged
feat(*) update project to build kumactl at windows #2597
bartsmykla
merged 5 commits into
kumahq:master
from
bartsmykla:feat/prepare-kumactl-for-windows-compilation
Aug 19, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bart Smykla <bartek@smykla.com>
c2538b3
to
639327a
Compare
Signed-off-by: Bart Smykla <bartek@smykla.com>
Signed-off-by: Bart Smykla <bartek@smykla.com>
Codecov Report
@@ Coverage Diff @@
## master #2597 +/- ##
==========================================
+ Coverage 52.24% 52.26% +0.01%
==========================================
Files 869 869
Lines 48593 48593
==========================================
+ Hits 25386 25395 +9
+ Misses 21163 21151 -12
- Partials 2044 2047 +3
Continue to review full report at Codecov.
|
jpeach
suggested changes
Aug 19, 2021
…actl-for-windows-compilation
Signed-off-by: Bart Smykla <bartek@smykla.com>
jakubdyszkiewicz
approved these changes
Aug 19, 2021
mergify bot
pushed a commit
that referenced
this pull request
Aug 19, 2021
(cherry picked from commit 1fc030e)
bartsmykla
added a commit
that referenced
this pull request
Aug 19, 2021
(cherry picked from commit 1fc030e) Signed-off-by: Bart Smykla <bartek@smykla.com>
bartsmykla
pushed a commit
that referenced
this pull request
Aug 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update project to allow build of kumactl for windows
Full changelog
no changelog
Issues resolved
It doesn't close the "distribute" part of this issue, but at least we are able to build it now: #366
Documentation
no documentation
Testing
Backwards compatibility
backport-to-stable
label if the code is backwards compatible. Otherwise, list breaking changes.