fix(dns) allow resolution of service names with "." #1448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This patch makes DNS resolution more restrictive so it's potentially not backward compatible depending on your treatment of undefined behavior as breaking changes. |
nickolaev
suggested changes
Jan 20, 2021
| // given | ||
| dnsResolver.SetVIPs(vips.List{ | ||
| "my.service": "240.0.0.1", | ||
| }) |
There was a problem hiding this comment.
If you do this in the It let's remove it from BeforeEach and put it in each It.
When specifying a `kuma.io/service` with a "." DNS resolution would not work because it would only look at the first part of the DNS name. This would also cause `foo.bar.mesh` and `foo.mesh` to resolve to the same thing which may give a false sense of isolation of meshes in the DNS We now only strips the last part of the DNS name if it matches the `.mesh` domain suffix. Signed-off-by: Charly Molter <charly@koyeb.com>
lahabana
force-pushed
the
fix/dns-with-dot
branch
from
b45000b to
11be298
Compare
|
@nickolaev updated thanks! |
|
@nickolaev seems like the build failure is unrelated can you retrigger the build? |
nickolaev
approved these changes
Jan 20, 2021
mergify bot
pushed a commit
that referenced
this pull request
Jan 20, 2021
When specifying a `kuma.io/service` with a "." DNS resolution would not work because it would only look at the first part of the DNS name. This would also cause `foo.bar.mesh` and `foo.mesh` to resolve to the same thing which may give a false sense of isolation of meshes in the DNS We now only strips the last part of the DNS name if it matches the `.mesh` domain suffix. Signed-off-by: Charly Molter <charly@koyeb.com> (cherry picked from commit de170f1)
nickolaev
pushed a commit
that referenced
this pull request
Jan 20, 2021
When specifying a `kuma.io/service` with a "." DNS resolution would not work because it would only look at the first part of the DNS name. This would also cause `foo.bar.mesh` and `foo.mesh` to resolve to the same thing which may give a false sense of isolation of meshes in the DNS We now only strips the last part of the DNS name if it matches the `.mesh` domain suffix. Signed-off-by: Charly Molter <charly@koyeb.com> (cherry picked from commit de170f1) Co-authored-by: Charly Molter <charly@koyeb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When specifying a
kuma.io/servicewith a "." DNS resolution would not workbecause it would only look at the first part of the DNS name.
This would also cause
foo.bar.meshandfoo.meshto resolve to the same thingwhich may give a false sense of isolation of meshes in the DNS
We now only strips the last part of the DNS name if it matches the
.meshdomain suffix.