fix(*) traffic logging to tcp backends

[nickolaev]

Summary

#894 actually broke TrafficLogs with TCP logger. It actually created a discrepancy in the naming of the UNIX socket between kuma-dp and the bootstrap generator in kuma-cp. In effect, Envoy was not able to find the GRPC logging service as provided by kuma-dp and the logs are never sent to the TCP logger.

Revert it and shorten the UNIX socket name by removing the not needed prefix kuma-access-logs-.

Issues resolved

Fix #853 (again)

Documentation

• Not needed

[lobkovilya]

Maybe it's better to create a function like:

func AccessLogPipeName(name, mesh string) string {
    return fmt.Sprintf("/tmp/%s-%s.sock", name, mesh)
}

and use it from both places? That'd allow avoiding bugs like this one, what do you think?

[jakubdyszkiewicz]

IMHO this does not solve the initial problem.

The problem was that if the name has more than 108 characters, it will fail. Even with getting rid of the kuma-access-logs- we can still easily hit the limit because the name can have up to 253 chars https://kubernetes.io/docs/concepts/overview/working-with-objects/names/#:~:text=This%20means%20the%20name%20must,no%20more%20than%20253%20characters

On top of that, I think it makes sense to mark this file that it is kuma access log socket, otherwise someone can just delete it.
My suggestion is to construct this kuma-al-{name}-{mesh} and trim this to 100 characters.