Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HtmlAgilityPack 1.7.3 can no longer be used in the project #164

Closed
JustArchi opened this issue Apr 7, 2018 · 4 comments
Closed

HtmlAgilityPack 1.7.3 can no longer be used in the project #164

JustArchi opened this issue Apr 7, 2018 · 4 comments
Assignees

Comments

@JustArchi
Copy link

JustArchi commented Apr 7, 2018

Please refer to my CI output:

CSC : error CS1685: The predefined type 'ExtensionAttribute' is defined in multiple assemblies in the global alias; using definition from 'HtmlAgilityPack, Version=1.7.3.0, Culture=neutral, PublicKeyToken=bd319b19eaf3b43a' [/home/travis/build/JustArchi/ArchiSteamFarm/ArchiSteamFarm/ArchiSteamFarm.csproj]

After reverting HAP back to 1.7.2, all is fine.

Very likely it's caused by specific configuration of my project, since other one does not suffer from this problem. I'm not sure if there is anything to fix on my side though, considering all versions up to 1.7.3 worked just fine, including 1.7.2.

Thank you in advance for looking into this.

@JustArchi JustArchi changed the title HtmlAgilityPack 1.7.3 can't no longer be used in the project HtmlAgilityPack 1.7.3 can no longer be used in the project Apr 7, 2018
@chrismsimpson
Copy link

Getting a similar error on vscode/dotnet 2.1.101. It seems like the warning is no longer being suppressed with the #pragma statement in src/HtmlAgilityPack.Shared/HtmlNode.Encapsulator.cs.

@JonathanMagnan JonathanMagnan self-assigned this Apr 8, 2018
@JonathanMagnan
Copy link
Member

Hello @JustArchi , @chrismsimpson

Thank you for reporting, we will look at it later today and we will try to provide a fix.

Best Regards,

Jonathan

@JonathanMagnan
Copy link
Member

Hello @JustArchi , @chrismsimpson ,

The v1.7.4 has been released.

Could you try it and let me know if everything is back to the normal?

Best Regards,

Jonathan

@JustArchi
Copy link
Author

I can confirm that the issue is solved on my side, lots of thanks @JonathanMagnan and the entire team! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants