Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does it support .net core ?? #13

Closed
tavisca-arvindy opened this issue Jun 5, 2017 · 14 comments
Closed

Does it support .net core ?? #13

tavisca-arvindy opened this issue Jun 5, 2017 · 14 comments
Assignees

Comments

@tavisca-arvindy
Copy link

No description provided.

@JonathanMagnan JonathanMagnan self-assigned this Jun 5, 2017
@JonathanMagnan
Copy link
Member

Hello @tavisca-arvindy ,

Since the v1.5.0, the library support .NET Core for NETSTANDARD 1.6

Let me know if that answer correctly to your question.

Best Regards,

Jonathan

@pendenaor
Copy link

pendenaor commented Jun 6, 2017

Hi,
The nuget seems broken, it targets netcore 4.5, which does not exist.

@pendenaor
Copy link

May i ask you if NetStandard 1.6 is truly needed ?

@JonathanMagnan
Copy link
Member

it targets netcore 4.5, which does not exist.

That was for Metro application which supports .NET "Core" 4.5 (Target Windows 8)

It was before the .NET Core we know today.

May i ask you if NetStandard 1.6 is truly needed?

It's for sure needed. That's the version that is used with .NET Core

Or perhaps I misunderstood your question?

Best Regards,

Jonathan

@pendenaor
Copy link

May i ask you if NetStandard 1.6 is truly needed?

It's for sure needed. That's the version that is used with .NET Core

Or perhaps I misunderstood your question?

My own lib, which depends on HAP, is NetStandard 1.1 and i would not want to rise it to 1.6.
Do you have some guidance about that?

@JonathanMagnan
Copy link
Member

The problem about .NETStandard 1.1 is almost nothing is supported that library requires.

By example, 3 of 4 packages on which HAP depend require .NETStandard 1.3 minimum:

So it could be possible to create a .NETStandard 1.3 packages but 1.1 will be close to impossible I believe since we don't have access to package required.

If we remove theses dependencies, I'm not sure how many functionalities we will remove!

We will soon support CSS Selectors like jQuery. Perhaps after we support it, I could check to see about the support for 1.1

You will not have access to XPath selectors, but at least you will have access to CSS Selectors.

Best Regards,

Jonathan

@pendenaor
Copy link

Thanks for your thorough answer.
Thinking back on it, NetStandard 1.3 sounds good to me.

Best regards,
Stéphane.

@JonathanMagnan
Copy link
Member

Great, we will try to support .NET Standard 1.3 during the weekend.

Best Regards,

Jonathan

@JonathanMagnan
Copy link
Member

Hello @pendenaor ,

We added support to the .NET Standard 1.3,

The new version should be available within a few hours.

Best Regards,

Jonathan

@JonathanMagnan
Copy link
Member

JonathanMagnan commented Jun 17, 2017

Hello @jonalbrecht , @pendenaor

The version v1.5.0-beta9 has been released:
https://www.nuget.org/packages/HtmlAgilityPack/1.5.0-beta9

Let us know if the support to .NET Standard 1.3 work correctly

Best Regards,

Jonathan

@pendenaor
Copy link

Sorry for the delay!
I'll test it soon.

@JonathanMagnan
Copy link
Member

Closing Comment: Feel free to re-open if you still have an issue.

@doggy8088
Copy link

doggy8088 commented Jan 20, 2019

@JonathanMagnan The .NETCore 4.5 target on NuGet is really confusing now. Are you considered to remove it? I never saw anyone using this target name.

@JonathanMagnan
Copy link
Member

Hello @doggy8088 ,

I have created a new issue to clean up dependencies on next release: #274

Since there are no dependencies on this framework, even if we continue to support it, we can hide it from the Dependencies section.

As you said, NETCore 4.5 is really confusing and I don't think it will bother anyone that this framework doesn't appear in that page section.

Thank for your suggestion.

Best Regards,

Jonathan


Performance Libraries
context.BulkInsert(list, options => options.BatchSize = 1000);
Entity Framework ExtensionsEntity Framework ClassicBulk OperationsDapper Plus

Runtime Evaluation
Eval.Execute("x + y", new {x = 1, y = 2}); // return 3
C# Eval FunctionSQL Eval Function

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants