Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What does W_c[c1; ...; cM] notation in the paper mean for character embeddings? #23

Open
brando90 opened this issue Dec 22, 2021 · 3 comments

Comments

@brando90
Copy link

The paper does not explain what the concatenation of vectors with the semicolon operation means. Can this be clarified?

Screen Shot 2021-12-22 at 3 50 25 PM

if we have n_i = W_c[c1; ...; cM], does this mean that W_c is a [1,M] vector and [c1; ...; cM] is a [M, D] matrix?

@zysszy
Copy link
Owner

zysszy commented Dec 24, 2021

The paper does not explain what the concatenation of vectors with the semicolon operation means. Can this be clarified?

Screen Shot 2021-12-22 at 3 50 25 PM

if we have n_i = W_c[c1; ...; cM], does this mean that W_c is a [1,M] vector and [c1; ...; cM] is a [M, D] matrix?

If we have n_i = W_c[c1; ...; cM], this mean that W_c is a [D, M * D] matrix and [c1; ...; cM] is a [M * D, 1] vector (implemented by torch.cat or tf.concat), where D is the hidden size.

@brando90
Copy link
Author

The paper does not explain what the concatenation of vectors with the semicolon operation means. Can this be clarified?
Screen Shot 2021-12-22 at 3 50 25 PM
if we have n_i = W_c[c1; ...; cM], does this mean that W_c is a [1,M] vector and [c1; ...; cM] is a [M, D] matrix?

If we have n_i = W_c[c1; ...; cM], this mean that W_c is a [D, M * D] matrix and [c1; ...; cM] is a [M * D, 1] vector (implemented by torch.cat or tf.concat), where D is the hidden size.

Thanks for the clarification. I think that is non-standard notation, perhaps you could write what that means in the paper next time? e.g. in the appendix if it's getting to long.

Thanks!

@zysszy
Copy link
Owner

zysszy commented Jan 8, 2022

The paper does not explain what the concatenation of vectors with the semicolon operation means. Can this be clarified?
Screen Shot 2021-12-22 at 3 50 25 PM
if we have n_i = W_c[c1; ...; cM], does this mean that W_c is a [1,M] vector and [c1; ...; cM] is a [M, D] matrix?

If we have n_i = W_c[c1; ...; cM], this mean that W_c is a [D, M * D] matrix and [c1; ...; cM] is a [M * D, 1] vector (implemented by torch.cat or tf.concat), where D is the hidden size.

Thanks for the clarification. I think that is non-standard notation, perhaps you could write what that means in the paper next time? e.g. in the appendix if it's getting to long.

Thanks!

Thanks for you advice~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants