Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tooltip): remove tooltips when element destroyed with event='hover' #33

Merged
merged 3 commits into from
Sep 21, 2018

Conversation

doug-a-brunner
Copy link
Contributor

I have a list of recent files in the Electron version of my app that changes when the contents of the file system do, and I found that when a file disappeared at the same time that I had a hover tooltip visible for it, that tooltip got stuck onscreen. This appears to fix the problem. I tried to create a unit test for it but found some very strange behavior:

  1. The setTimeout functions used on the existing tests are never called. It seems as though they should be using Jasmine's done() mechanism to force the test to wait for the timeout function.
  2. When I tried doing this, or creating a test for hover by calling timeout.onMouseEnter() and timeout.onMouseLeave(), calling expect(tooltip.tooltipElement).toBeUndefined() caused the browser to hang.

@danielsogl
Copy link
Contributor

please rebase on master

@madoBaker madoBaker merged commit 310d968 into zyra:master Sep 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants