Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plug-in crashes when Humidifier added to account #27

Closed
arbnknight opened this issue Nov 15, 2023 · 6 comments
Closed

Plug-in crashes when Humidifier added to account #27

arbnknight opened this issue Nov 15, 2023 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@arbnknight
Copy link

arbnknight commented Nov 15, 2023

Describe The Bug:
Added a humidifier device to my account. Since then the plug-in is caught in a restart loop and seems to bring the child bridge with it.

To Reproduce:
add a Dreo 6L HM713S humidifier to your account and wait for the plug-in to poll for it.

Expected behavior:
Filing a bug since plug in shouldn’t stop with humidifier added but should ignore it. I will file an enhancement separately for humidifier support (happy to help too).

Logs:


[11/14/2023, 10:55:01 PM] [Dreo Platform] Adding new accessory: Humidifier
TypeError: Cannot read properties of undefined (reading '1')
    at new FanAccessory (/var/lib/homebridge/node_modules/homebridge-dreo/src/FanAccessory.ts:38:75)
    at DreoPlatform.discoverDevices (/var/lib/homebridge/node_modules/homebridge-dreo/src/platform.ts:150:9)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
[11/14/2023, 10:55:01 PM] [Dreo Platform] Child bridge process ended
[11/14/2023, 10:55:01 PM] [Dreo Platform] Process Ended. Code: 1, Signal: null

Plugin Config:

"hideTemperatureSensor": false,
            "temperatureOffset": 0,

Screenshots:
N/A

Environment:

  • Plugin Version: 3.2.2
  • Homebridge Version: 1.7.0
  • Node.js Version: 18.16.0
  • NPM Version: 9.5.1
  • Operating System: Ubuntu
@arbnknight arbnknight added the bug Something isn't working label Nov 15, 2023
@arbnknight
Copy link
Author

Corresponding enhancement filed here: #28

@brentmw
Copy link

brentmw commented Jan 5, 2024

I get the same error. Is there a workaround? Or do I need to remove the humidifier from my Dreo account for the plugin to work?

@rizaus
Copy link

rizaus commented Feb 5, 2024

Same, bought the humidifier and wondered why my fan suddenly stopped working.

@zyonse
Copy link
Owner

zyonse commented Feb 5, 2024

@rizaus @brentmw @mja00 Please test v3.2.5-beta.0 and let me know if that fixes the crashing. You can install it by going to homebridge > plugins > homebridge-dreo > manage version

@mja00
Copy link

mja00 commented Feb 5, 2024

Can confirm it's fixed

[2/5/2024, 1:59:37 PM] [Dreo Platform] Launched child bridge with PID 25390
[2/5/2024, 1:59:37 PM] Registering platform 'homebridge-dreo.DreoPlatform'
[2/5/2024, 1:59:37 PM] [Dreo Platform] Loaded homebridge-dreo v3.2.5-beta.0 child bridge successfully
[2/5/2024, 1:59:37 PM] Homebridge v1.7.0 (HAP v0.11.1) (Dreo Platform) is running on port 53730.
[2/5/2024, 1:59:37 PM] [Dreo Platform] Country: US
[2/5/2024, 1:59:37 PM] [Dreo Platform] Region: NA
[2/5/2024, 1:59:38 PM] [Dreo Platform] Adding new accessory: Garage Heater
[2/5/2024, 1:59:38 PM] [Dreo Platform] Adding new accessory: Living room 
[2/5/2024, 1:59:38 PM] [Dreo Platform] Adding new accessory: Bedroom Fan

@rizaus
Copy link

rizaus commented Feb 5, 2024

That got it working again. It now sees the Humidifier and doesn't recognize the device type (expected result). So it's all good on my end.

@zyonse zyonse closed this as completed Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants