Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faster document listing by directly loading ref docs #1763

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

imartinez
Copy link
Collaborator

Improves the speed of launching PrivateGPT's UI when lots of documents are ingested.
Improves the speed of the "list" API.

@dbzoo
Copy link
Contributor

dbzoo commented Mar 20, 2024

Testing using Postgres 14 docstore with 2,421,062 rows

With PR 1763 elapsed time 12s

22:58:37.941 [INFO    ] llama_index.core.indices.loading - Loading all indices.
22:58:49.454 [INFO    ]         private_gpt.ui.ui - Mounting the gradio UI, at path=/

Without change - 4m 50s

23:00:13.423 [INFO    ] llama_index.core.indices.loading - Loading all indices.
23:05:03.283 [INFO    ]         private_gpt.ui.ui - Mounting the gradio UI, at path=/

This work. Good job. Ship it !

@imartinez
Copy link
Collaborator Author

Testing using Postgres 14 docstore with 2,421,062 rows

With PR 1763 elapsed time 12s

22:58:37.941 [INFO    ] llama_index.core.indices.loading - Loading all indices.
22:58:49.454 [INFO    ]         private_gpt.ui.ui - Mounting the gradio UI, at path=/

Without change - 4m 50s

23:00:13.423 [INFO    ] llama_index.core.indices.loading - Loading all indices.
23:05:03.283 [INFO    ]         private_gpt.ui.ui - Mounting the gradio UI, at path=/

This work. Good job. Ship it !

Thanks for the test and the stats!

@imartinez imartinez merged commit 348df78 into main Mar 20, 2024
6 checks passed
@imartinez imartinez deleted the feature/ui-loading-speed branch March 20, 2024 18:11
imartinez added a commit that referenced this pull request Mar 20, 2024
* added request_timeout to ollama, default set to 30.0 in settings.yaml and settings-ollama.yaml

* Update settings-ollama.yaml

* Update settings.yaml

* updated settings.py and tidied up settings-ollama-yaml

* feat(UI): Faster startup and document listing (#1763)

* fix(ingest): update script label (#1770)

huggingface -> Hugging Face

* Fix lint errors

---------

Co-authored-by: Stephen Gresham <steve@gresham.id.au>
Co-authored-by: Ikko Eltociear Ashimine <eltociear@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants