Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple skips in a playlist/folder causes ModernX to give up. #14

Closed
lostb053 opened this issue Feb 26, 2024 · 8 comments
Closed

Multiple skips in a playlist/folder causes ModernX to give up. #14

lostb053 opened this issue Feb 26, 2024 · 8 comments
Assignees

Comments

@lostb053
Copy link

Error description:

The interface of ModernX (i think it's called OSC) no longer shows up

Steps to reproduce:

  • Have a folder with multiple medias (preferably without chapters)
  • play the folder
  • keep jumping to the next video

Additional remarks: I noticed that this doesn't happen when i navigate like this slowly. In the process I noticed that it takes just a little while for OSC to load up completely with size and title n stuff. My assumption is that navigating too quickly results into this situation because script be initially bz sorting out loading for previous file, but i am already on the next one.

Settings (ModernX)

Note: This .conf file was initially imported from other .conf file while i was using other fork earlier. While i think i've made all necessary changes, feel free to point out any issues here if any.

# ---------------- #
# mpv user options #
# ---------------- #

# Duration of fade out in ms
fadeduration=500

# Size ratio of the knob handle
seekbarhandlesize=1


# -------------------- #
# ModernX user options #
# -------------------- #

# Prevent OSC from showing on pause
showonpause=no

# Show title in OSC
showtitle=yes

# =====
# Note: ASS tag's color code is given in BGR, instead of the standard RGB.
# Read the section for "Set color" here:
# https://aeg-dev.github.io/AegiSite/docs/3.2/ass_tags/
# =====

# Accent of the OSC and the title bar
osc_color=000000

# Color of the seekbar progress and handle
seekbarfg_color=E39C42

# Color of the remaining seekbar
seekbarbg_color=FFFFFF

bottomhover=no
showinfo=yes
thumbnailborder=0
showloop=yes
compactmode=no

Screenshot

This screenshot is derived from some logs i think that show up when u press ` in mpv

image

Feel free to contact for any required info.

@zydezu zydezu self-assigned this Feb 27, 2024
@zydezu
Copy link
Owner

zydezu commented Feb 29, 2024

I can't recreate this so far. What type of drive are these videos stored on (like a HDD)?

@lostb053
Copy link
Author

lostb053 commented Feb 29, 2024

They are on SSD, but ig the power saving mode restricts the speed of OSC/player? This situation might be very specific for my laptop in that case. Or is it because I'm using bunch of other plugins as well? Does that matter as such? I'm not sure.
Or is it the sheer size of files? As in because the files are it's taking a lil longer. I'm using about 24 files 1.4gb each. Though i highly doubt that would matter

Also note that I'm not really waiting for OSC to load each time i press the PgDwn button (keybinding for Next Video). So like about 3-4 presses/second? See if that helps.

If you are still unable to recreate the issue, is there any way you could still help?

@lostb053
Copy link
Author

lostb053 commented Feb 29, 2024

Uh, also i mentioned videos preferably without chapters, because I've a plug-in which lets me skip chapters instead of videos when i use PgDwn. That also was very specific for me. If you're not using such plug-in, ignore that as well.

@zydezu
Copy link
Owner

zydezu commented Mar 19, 2024

I could try and release versions of the code to see if it fixes it on your part... what plug-ins are you using by the way...

@lostb053
Copy link
Author

Hello. Thx for the reply. Actually i got exams ongoing rn, I'll reply later with time if you don't mind.

@zydezu
Copy link
Owner

zydezu commented Apr 20, 2024

This commit zydezu/mpvconfig@309a291 / the next release addresses a crash related to skipping videos, this could fix the problem

@lostb053
Copy link
Author

Hey there, I am extremely sorry for failing at giving you the response. I'll be honest, I had forgotten.
Here is my mpv script setup. Some scripts taken from you, some from others.

mpv.zip

I'll try the update today, and reply you soon.
Thnx for the update, and also thnx for the follow up.

@lostb053
Copy link
Author

Hey, so i come with more info.

Screenshot 2024-04-20 160355

I say about 5-6 clicks/second

To be noted: It's working much better now. But I still got following error

Screenshot 2024-04-20 161413

As for me, I think I am satisfied by how it's working now.
maybe just occasional crashes. Feel free to improve if you wish (of course that's well appreciated as well)
Thanks again for the update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants