-
-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui, zwaveclient): learn/secondary controller mode #4097
base: master
Are you sure you want to change the base?
Conversation
@ArtemKiyashko Thanks for your PR, I was waiting before implementing this as @AlCalzone told me this is not ready for production yet. But I think we could maybe make this clear in the confirm text. @AlCalzone WDYT? |
{ | ||
name: 'Start', | ||
action: 'startLearnMode', | ||
args: { | ||
confirm: | ||
'Initiate learn mode on primary controller first and then click OK here.', | ||
}, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would also add the stop action here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also it may have more sense to add this to the nodes manager dialog IMO |
Not sure if this is node specific functionality, because this is controller level function. E.g. no sense to show this option in Node dialog for controlled devices. But i can move this option to node dialog if you wish |
Let's see what @AlCalzone opinion about this :) For me it could be ok also as it is now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from code side 👍🏼
not sure what is wrong here: https://github.com/zwave-js/zwave-js-ui/actions/runs/12868729333/job/35876826584?pr=4097#step:5:15 :) |
@zwave-js-bot fix lint |
@ArtemKiyashko Lint issues, you should run |
Ok seems bot is having some issues: https://github.com/zwave-js/zwave-js-ui/actions/runs/12869249637/job/35877613209 @ArtemKiyashko could you do that please? Just run that command and it will fix lint |
Ok, seems it was "newline" issue. Should be good now
|
Pull Request Test Coverage Report for Build 12869310829Details
💛 - Coveralls |
Add support of "learn mode". Controller can be added to pre-existing network and used as "secondary" controller.
Driver function ref
From Aeotec user manual:
Screenshots: