From 656e3dd01c926897f28e1e5c3a4a80f0448d821e Mon Sep 17 00:00:00 2001 From: Dominic Griesel Date: Sun, 10 Mar 2019 21:17:57 +0100 Subject: [PATCH 1/2] Exclude build dir from LGTM checks --- .lgtm.yml | 3 +++ 1 file changed, 3 insertions(+) create mode 100644 .lgtm.yml diff --git a/.lgtm.yml b/.lgtm.yml new file mode 100644 index 000000000000..1527feae41e8 --- /dev/null +++ b/.lgtm.yml @@ -0,0 +1,3 @@ +path_classifiers: + generated: + - build From e8ee3cc72e5dea60602e73513000d5867c4f97f2 Mon Sep 17 00:00:00 2001 From: Dominic Griesel Date: Sun, 10 Mar 2019 21:19:37 +0100 Subject: [PATCH 2/2] Fix broken loop condition --- build/lib/driver/Driver.js | 2 +- src/lib/driver/Driver.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/build/lib/driver/Driver.js b/build/lib/driver/Driver.js index 6e4993c2412e..f2838e931f52 100644 --- a/build/lib/driver/Driver.js +++ b/build/lib/driver/Driver.js @@ -532,7 +532,7 @@ class Driver extends events_1.EventEmitter { if (handlers != null && handlers.length > 0) { logger_1.log("driver", ` ${handlers.length} handler${handlers.length !== 1 ? "s" : ""} registered!`, "debug"); // loop through all handlers and find the first one that returns true to indicate that it handled the message - for (let i = 0; i <= handlers.length; i++) { + for (let i = 0; i < handlers.length; i++) { logger_1.log("driver", ` invoking handler #${i}`, "debug"); const handler = handlers[i]; if (handler.invoke(msg)) { diff --git a/src/lib/driver/Driver.ts b/src/lib/driver/Driver.ts index 7cea3a1b073f..76155e23ff14 100644 --- a/src/lib/driver/Driver.ts +++ b/src/lib/driver/Driver.ts @@ -638,7 +638,7 @@ export class Driver extends EventEmitter implements IDriver { if (handlers != null && handlers.length > 0) { log("driver", ` ${handlers.length} handler${handlers.length !== 1 ? "s" : ""} registered!`, "debug"); // loop through all handlers and find the first one that returns true to indicate that it handled the message - for (let i = 0; i <= handlers.length; i++) { + for (let i = 0; i < handlers.length; i++) { log("driver", ` invoking handler #${i}`, "debug"); const handler = handlers[i]; if (handler.invoke(msg)) {