Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Strips Drip 700] Some configurations have incorrect size and some incorrect name #6509

Closed
4 of 7 tasks
AlCalzone opened this issue Nov 21, 2023 Discussed in #6508 · 3 comments
Closed
4 of 7 tasks

Comments

@AlCalzone
Copy link
Member

Discussed in #6508

Originally posted by @dparyani November 21, 2023

Checklist

  • I have read and followed the above instructions

  • I have checked the troubleshooting section and my problem is not described there.

  • I have read the changelog and my problem was not mentioned there or the fix did not work.

Describe the issue

What is happening?

  1. Configuration changes for [NodeId-112-0-7] and [NodeId-112-0-8] are rejected by Strips Drip 700. On closer investigation it was found that wrong configuration size is hard-coded in the JSON file.
    https://github.com/zwave-js/node-zwave-js/blob/master/packages/config/config/devices/0x019a/11_04_21_22_28.json

  2. Reviewing the above mentioned file showed further incorrect discrepancies. For e.g. [NodeId-112-0-4] has incorrect configuration name.

What did you expect to happen instead?
Sensative expected for these configurations to reflect and work as expected and as mentioned in the device manual.

Steps to reproduce the behavior:

  1. Pair Strips Drip 700 with Home Assistant
  2. Enable configuration parameter [NodeId-112-0-6] Temperature Alarms.
  3. Change and queue configuration changes for parameters [NodeId-112-0-7] and [NodeId-112-0-8].
  4. Manual Wake-Up Strips.
  5. Try to change the environment temperature around Strips Drip 700. e.g. Use a hair dryer to increase the temperature or an ice or pre-freezed package to lower the temperature.
  6. Check the temperature levels at which the alarms trigger. They will not be similar to what the values were being set in step 3.
  7. Alternatively, one can poll for parameters [NodeId-112-0-7] and [NodeId-112-0-8]

Anything else we should know?
Sensative will fix this and create a pull request

Software versions

Driver (node-zwave-js): ...

Z-Wave JS UI: 2.2.3

Home Assistant Z-Wave Core: 2023.10.5

Home Assistant OS: 11.0

Home Assistant Z-Wave JS Addon: ...

ioBroker.zwave2 Adapter: ...

If you are using something non-standard, tell us here: ...

Device information

Manufacturer: Sensative (0x019A)
Model name: "11 04 021/022/028"

Checklist

  • I made sure to provide a driver log on level debug.

  • The log includes a re-interview of the problematic device (if applicable).

  • The log includes the problematic interaction with the device (if applicable).

  • I provided the node ID of the problematic device (if applicable).

Upload Logfile

No response

@dparyani
Copy link
Contributor

Hello @AlCalzone,

It seems I do not have the rights to push my private branch to generate a pull request.

Attaching the affected file here...

11_04_21_22_28.json

@AlCalzone
Copy link
Member Author

@dparyani to create a pull request, you have to make a fork, commit/push the changes there and then create a pull request from your fork.

Doing that would be easier, since the file is automatically checked.

@AlCalzone
Copy link
Member Author

It appears that the file matches our current file now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants