Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2D/3D code duplication #12

Open
zvxryb opened this issue Mar 21, 2020 · 1 comment
Open

2D/3D code duplication #12

zvxryb opened this issue Mar 21, 2020 · 1 comment

Comments

@zvxryb
Copy link
Owner

zvxryb commented Mar 21, 2020

Some code was duplicated in the process of implementing 2D indices (issue #6).

Much of the code in index.rs (structs and SpatialIndex trait implementations) is already generated by a macro to avoid duplication. However, 2D/3D algorithms in geom.rs have a great deal of similarity and opportunities for improvement still exist.

@zvxryb
Copy link
Owner Author

zvxryb commented Mar 21, 2020

Const generics and a number of other future Rust features might be helpful here, so I may postpone this until Rust generics are a bit more complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant