Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

callOnEachEvent does not forward event types correctly #108

Closed
palaga opened this issue Oct 11, 2024 · 0 comments · Fixed by #109
Closed

callOnEachEvent does not forward event types correctly #108

palaga opened this issue Oct 11, 2024 · 0 comments · Fixed by #109

Comments

@palaga
Copy link
Contributor

palaga commented Oct 11, 2024

Can be easily reproduced by running queue_helper.js from the examples directory. Update the zuliprc file path, so it points to a valid rc, and run the example script. Now type a message in some chat and monitor the output of the example script. Typing events will pop up, while only message events are expected.

After inspecting the source, it looks like the parameter is passed as eventType instead of event_type.

Renaming all instances of eventType with event_type in events_wrapper.js seems to fix it, except that I keep seeing heartbeat events. Just renaming might not be an elegant solution, as it goes against naming conventions, but it should be easy to fix nonetheless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant