inconsistencies in flags #3
Comments
|
Also |
|
Interestingly, things work on my mac without the "cdylib" here: https://github.com/zshipko/ocaml-rust-starter/blob/master/Cargo.toml#L8 but don't work with it |
|
Thanks for the report!
That is actually in
These are needed on linux
I'm happy to review a PR with that update
What things don't work? Can you please provide a little more information or an error message? |
|
here's the error I get when I try to compile with cdylib: |
|
I've found that using the following in a fn main() {
if cfg!(any(target_os = "macos", target_os = "ios")) {
println!("cargo:rustc-link-arg=-Wl,-undefined,dynamic_lookup");
}
}works well as long as you have rust-lang/cargo#9557 (Rust 1.56.0). (I'm added iOS since I suspect it has the same problem) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The docs says you should add some flags to
Cargo.tomlon MacOS:yet we don't do it here: https://github.com/zshipko/ocaml-rust-starter/blob/master/Cargo.toml
yet (bis) it works fine on my mac without these build flags.
Second, why the C flags here? https://github.com/zshipko/ocaml-rust-starter/blob/master/src/dune#L17
It works fine on my mac without these :o
The text was updated successfully, but these errors were encountered: