-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: open Zowe Explorer resources using VSCode URLs #3271
Conversation
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3271 +/- ##
=======================================
Coverage 93.07% 93.07%
=======================================
Files 113 114 +1
Lines 11763 11784 +21
Branches 2656 2660 +4
=======================================
+ Hits 10948 10968 +20
- Misses 813 814 +1
Partials 2 2 ☔ View full report in Codecov by Sentry. |
📅 Suggested merge-by date: 11/6/2024 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
haven't tested it yet, but the changes LGTM! 😋
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
No problem 😁
Sorry @zFernand0, I misunderstood your question. I think it shouldn't adjust the search filter as an external link is considered a direct lookup of a Zowe resource - it works independently of the tree views and only leverages the FileSystemProvider. |
Thanks for adding the license headers too 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made a suggestion for edits to the changelog
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good changelog @traeok!
We're not in a place to easily support directories and PDS right now. We can add support for this in the future once its easy to access the profile node and execute a search on it programatically. Signed-off-by: Trae Yelovich <trae.yelovich@broadcom.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @traeok!
Proposed changes
Enables users to click VSCode URLs directed at our extension. We can parse and handle these URIs to open given resource paths or execute commands (depending on the contents).
For now, I've only added the
vscode.open
functionality. In the future, we can expose and execute commands if desired.Example:
vscode://Zowe.vscode-extension-for-zowe?zowe-ds:/lpar.zosmf/CUSTOMER.PUBLIC.REXX/SAYHELLO
vscode://Zowe.vscode-extension-for-zowe?zowe-uss:/lpar.zosmf/u/path/to/customer/homedir
Adjust the URLs above to match a Data Set or USS resource under one of your profiles. Then paste the link in your browser to open it within VS Code. Ensure that either:
Release Notes
Milestone: 3.1.0
Changelog:
vscode://Zowe.vscode-extension-for-zowe?zowe-ds:/lpar.zosmf/TEST.PDS/MEMB
will open theMEMB
PDS member under theTEST.PDS
using thelpar.zosmf
profile.Types of changes
Checklist
General
yarn workspace vscode-extension-for-zowe vscode:prepublish
pnpm --filter vscode-extension-for-zowe vscode:prepublish
Code coverage
Deployment