Identical member names - PDS enhancement #2427

pujal0909 · 2025-02-03T20:42:18Z

What It Does

When copying PDSs, if the source and target have identical member names, the default behavior now is to prompt the user to confirm before overwriting the members contents (when the safe-replace option is not set to true). If the user uses the replace flag, it bypasses the prompt.

How to Test

Copy a source PDS into a target PDS, with both having members with the same names.
Notice that a prompt appears where you can select 'y/N'
Now copy the same source PDS into the same target PDS with the replace option.
Notice that the prompt is skipped

Review Checklist
I certify that I have:

tested my changes
added/updated automated tests
updated the changelog
followed the contribution guidelines

Additional Comments

Signed-off-by: Pujal <pujal.gandhi@broadcom.com>

packages/cli/__tests__/zosfiles/__unit__/copy/ds/Ds.handler.unit.test.ts

packages/zosfiles/__tests__/__unit__/methods/copy/Copy.unit.test.ts

packages/zosfiles/src/methods/copy/Copy.ts

Signed-off-by: Pujal <pujal.gandhi@broadcom.com>

codecov · 2025-02-03T20:53:16Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.50%. Comparing base (eb5696b) to head (0775bf4).
Report is 25 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #2427   +/-   ##
=======================================
  Coverage   91.49%   91.50%           
=======================================
  Files         641      641           
  Lines       18360    18376   +16     
  Branches     3869     3946   +77     
=======================================
+ Hits        16799    16815   +16     
  Misses       1559     1559           
  Partials        2        2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Pujal <pujal.gandhi@broadcom.com>

github-actions · 2025-02-04T14:56:10Z

📅 Suggested merge-by date: 2/18/2025

Signed-off-by: Pujal <pujal.gandhi@broadcom.com>

anaxceron

Left some comments, please review.

packages/cli/__tests__/zosfiles/__unit__/copy/ds/Ds.handler.unit.test.ts

packages/cli/src/zosfiles/copy/ds/Ds.handler.ts

packages/cli/__tests__/zosfiles/__unit__/copy/ds/Ds.handler.unit.test.ts

packages/cli/src/zosfiles/copy/ds/Ds.handler.ts

packages/zosfiles/CHANGELOG.md

Signed-off-by: Pujal <pujal.gandhi@broadcom.com>

packages/zosfiles/src/methods/copy/doc/ICopyDatasetOptions.ts

packages/cli/CHANGELOG.md

packages/zosfiles/CHANGELOG.md

Signed-off-by: Pujal <pujal.gandhi@broadcom.com>

zFernand0

LGTM! 😋

I did leave some comments for possible improvements, but I do like the code as-is and works as expected 🙏

packages/zosfiles/src/methods/copy/Copy.ts

packages/cli/CHANGELOG.md

Signed-off-by: Pujal <pujal.gandhi@broadcom.com>

traeok

Changes LGTM, thanks @pujal0909 for enhancing the copy PDS command!

Signed-off-by: Pujal <pujal.gandhi@broadcom.com>

packages/zosfiles/__tests__/__system__/methods/copy/Copy.system.test.ts

packages/zosfiles/__tests__/__unit__/methods/copy/Copy.unit.test.ts

Signed-off-by: Pujal <pujal.gandhi@broadcom.com>

github-actions · 2025-02-16T11:02:41Z

Reminder: This pull request has a merge-by date coming up within the next 24 hours. Please review this PR as soon as possible.

@t1m0thyj @awharn @ATorrise @adam-wolfe @jace-roell

t1m0thyj

Looks pretty good, thanks @pujal0909! Left a few comments

packages/cli/CHANGELOG.md

packages/zosfiles/__tests__/__system__/methods/copy/Copy.system.test.ts

packages/zosfiles/src/constants/ZosFiles.messages.ts

Signed-off-by: Pujal <pujal.gandhi@broadcom.com>

t1m0thyj

LGTM, thanks @pujal0909!

awharn

This PR looks good, but there is a duplicate import in the system test that needs to be addressed.

packages/zosfiles/__tests__/__system__/methods/copy/Copy.system.test.ts

Signed-off-by: Pujal <pujal.gandhi@broadcom.com>

changes addressed

Signed-off-by: Pujal Gandhi <71276682+pujal0909@users.noreply.github.com>

awharn

Looks good to me, thanks @pujal0909!

Signed-off-by: Pujal Gandhi <71276682+pujal0909@users.noreply.github.com>

sonarqubecloud · 2025-02-20T14:13:43Z

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

pujal0909 added 2 commits February 3, 2025 15:38

like named members functionality for PDSs

48f7d87

Signed-off-by: Pujal <pujal.gandhi@broadcom.com>

updates

1575d46

Signed-off-by: Pujal <pujal.gandhi@broadcom.com>

github-actions bot assigned pujal0909 Feb 3, 2025

github-advanced-security bot found potential problems Feb 3, 2025

View reviewed changes

changelogs

3d24f6d

Signed-off-by: Pujal <pujal.gandhi@broadcom.com>

updated unit tests

471e754

Signed-off-by: Pujal <pujal.gandhi@broadcom.com>

pujal0909 marked this pull request as ready for review February 4, 2025 14:55

pujal0909 requested review from zFernand0, traeok and anaxceron February 4, 2025 14:56

pujal0909 requested review from t1m0thyj, awharn, ATorrise and adam-wolfe February 4, 2025 14:56

pujal0909 added 3 commits February 5, 2025 11:46

updated like-named terminology to identical member names

9911d18

Signed-off-by: Pujal <pujal.gandhi@broadcom.com>

updated snapshots

bc51780

Signed-off-by: Pujal <pujal.gandhi@broadcom.com>

updates to code

059e305

Signed-off-by: Pujal <pujal.gandhi@broadcom.com>

anaxceron reviewed Feb 6, 2025

View reviewed changes

updates to changelogs

7c605b6

Signed-off-by: Pujal <pujal.gandhi@broadcom.com>

anaxceron approved these changes Feb 6, 2025

View reviewed changes

pujal0909 added 2 commits February 6, 2025 15:23

updated likeNamed to Identical

653b138

Signed-off-by: Pujal <pujal.gandhi@broadcom.com>

updated changelog

1786f7b

Signed-off-by: Pujal <pujal.gandhi@broadcom.com>

traeok reviewed Feb 6, 2025

View reviewed changes

packages/zosfiles/src/methods/copy/doc/ICopyDatasetOptions.ts Show resolved Hide resolved

packages/cli/CHANGELOG.md Outdated Show resolved Hide resolved

packages/zosfiles/CHANGELOG.md Outdated Show resolved Hide resolved

updated changelog to bugfix

1cb28c7

Signed-off-by: Pujal <pujal.gandhi@broadcom.com>

pujal0909 changed the title ~~Like named PDS members enhancement~~ Identical member names - PDS enhancement Feb 7, 2025

pujal0909 requested a review from traeok February 7, 2025 16:25

zFernand0 approved these changes Feb 9, 2025

View reviewed changes

packages/zosfiles/src/methods/copy/Copy.ts Outdated Show resolved Hide resolved

packages/cli/CHANGELOG.md Outdated Show resolved Hide resolved

merged master

97ebc8b

Signed-off-by: Pujal <pujal.gandhi@broadcom.com>

pujal0909 added 3 commits February 10, 2025 09:39

updated changelog

5726d31

Signed-off-by: Pujal <pujal.gandhi@broadcom.com>

fixed changelog error

5751f53

Signed-off-by: Pujal <pujal.gandhi@broadcom.com>

updated system tests

476f2a1

Signed-off-by: Pujal <pujal.gandhi@broadcom.com>

traeok approved these changes Feb 10, 2025

View reviewed changes

pujal0909 requested a review from jace-roell February 12, 2025 01:03

list.allMembers call is cached

8063ce4

Signed-off-by: Pujal <pujal.gandhi@broadcom.com>

github-advanced-security bot found potential problems Feb 12, 2025

View reviewed changes

packages/zosfiles/__tests__/__system__/methods/copy/Copy.system.test.ts Dismissed Show dismissed Hide dismissed

packages/zosfiles/__tests__/__unit__/methods/copy/Copy.unit.test.ts Fixed Show fixed Hide fixed

removed unsused variable

eeeb755

Signed-off-by: Pujal <pujal.gandhi@broadcom.com>

t1m0thyj requested changes Feb 19, 2025

View reviewed changes

packages/cli/CHANGELOG.md Show resolved Hide resolved

packages/zosfiles/__tests__/__system__/methods/copy/Copy.system.test.ts Outdated Show resolved Hide resolved

packages/zosfiles/src/constants/ZosFiles.messages.ts Outdated Show resolved Hide resolved

merged with master

349e3fe

Signed-off-by: Pujal <pujal.gandhi@broadcom.com>

pujal0909 force-pushed the duplicate-pds-members branch from 133a470 to 349e3fe Compare February 19, 2025 14:35

updated changelog & system test

769d902

Signed-off-by: Pujal <pujal.gandhi@broadcom.com>

pujal0909 requested a review from t1m0thyj February 19, 2025 15:33

updated changelogs

ee0a485

Signed-off-by: Pujal <pujal.gandhi@broadcom.com>

pujal0909 force-pushed the duplicate-pds-members branch from 3991e23 to ee0a485 Compare February 19, 2025 17:15

t1m0thyj approved these changes Feb 19, 2025

View reviewed changes

awharn previously requested changes Feb 19, 2025

View reviewed changes

packages/zosfiles/__tests__/__system__/methods/copy/Copy.system.test.ts Outdated Show resolved Hide resolved

removed repeat import in copy.system.testcd

c87e957

Signed-off-by: Pujal <pujal.gandhi@broadcom.com>

pujal0909 force-pushed the duplicate-pds-members branch from a6936bc to c87e957 Compare February 19, 2025 19:37

pujal0909 requested a review from awharn February 19, 2025 20:14

Merge branch 'master' into duplicate-pds-members

071b565

Signed-off-by: Pujal Gandhi <71276682+pujal0909@users.noreply.github.com>

awharn approved these changes Feb 19, 2025

View reviewed changes

Merge branch 'master' into duplicate-pds-members

0775bf4

Signed-off-by: Pujal Gandhi <71276682+pujal0909@users.noreply.github.com>

t1m0thyj merged commit b91b989 into master Feb 20, 2025
23 checks passed

t1m0thyj deleted the duplicate-pds-members branch February 20, 2025 14:33

t1m0thyj added the release-current Indicates that there is no new functionality being delivered label Feb 20, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Identical member names - PDS enhancement #2427

Identical member names - PDS enhancement #2427

pujal0909 commented Feb 3, 2025 •

edited

Loading

codecov bot commented Feb 3, 2025 •

edited

Loading

github-actions bot commented Feb 4, 2025

anaxceron left a comment

zFernand0 left a comment

traeok left a comment

github-actions bot commented Feb 16, 2025

t1m0thyj left a comment

t1m0thyj left a comment

awharn left a comment

awharn left a comment

sonarqubecloud bot commented Feb 20, 2025

Identical member names - PDS enhancement #2427

Identical member names - PDS enhancement #2427

Conversation

pujal0909 commented Feb 3, 2025 • edited Loading

codecov bot commented Feb 3, 2025 • edited Loading

Codecov Report

github-actions bot commented Feb 4, 2025

anaxceron left a comment

Choose a reason for hiding this comment

zFernand0 left a comment

Choose a reason for hiding this comment

LGTM! 😋

traeok left a comment

Choose a reason for hiding this comment

github-actions bot commented Feb 16, 2025

t1m0thyj left a comment

Choose a reason for hiding this comment

t1m0thyj left a comment

Choose a reason for hiding this comment

awharn left a comment

Choose a reason for hiding this comment

awharn left a comment

Choose a reason for hiding this comment

sonarqubecloud bot commented Feb 20, 2025

Quality Gate passed

pujal0909 commented Feb 3, 2025 •

edited

Loading

codecov bot commented Feb 3, 2025 •

edited

Loading