Deprecate old getDataSet in v2 LTS, move to zosfiles SDK #1977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
awharn
requested review from
t1m0thyj,
gejohnston,
zFernand0,
traeok,
KevinLoesch1 and
ATorrise
zFernand0
requested changes
Nov 28, 2023
Comment on lines
+17
to
20
| * @deprecated - use @zowe/zos-files-for-zowe-sdk's ZosFilesUtils.getDataSetFromName instead | ||
| * Converts the name of a data set to an IDataSet | ||
| * @param {string} name - the name in the form USER.DATA.SET | USER.DATA.SET(mem1) | ||
| */ |
There was a problem hiding this comment.
Alongside the deprecation message, should we call the getDataSetFromName method here?
That way, if there is ever a bug in the method, we can fix in in one place? 😋
I don't think doing this will cause a circular dependency since the CLI package already imports the files sdk 😋
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1977 +/- ##
==========================================
- Coverage 91.04% 91.03% -0.02%
==========================================
Files 636 636
Lines 18712 18713 +1
Branches 3898 3898
==========================================
- Hits 17037 17035 -2
- Misses 1674 1677 +3
Partials 1 1 ☔ View full report in Codecov by Sentry. |
gejohnston
approved these changes
Nov 28, 2023
Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
Signed-off-by: Andrew W. Harn <andrew.harn@broadcom.com>
zFernand0
approved these changes
Nov 28, 2023
|
Kudos, SonarCloud Quality Gate passed! |
|
Release succeeded for the The following packages have been published:
Powered by Octorelease 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What It Does
Copies getDataSet to the zosFiles SDK under the new name, and deprecates the original function
How to Test
Review Checklist
I certify that I have:
Additional Comments