Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Daily classification counts persist across projects #5134

Open
eatyourgreens opened this issue Aug 9, 2023 · 3 comments · May be fixed by #6401
Open

Daily classification counts persist across projects #5134

eatyourgreens opened this issue Aug 9, 2023 · 3 comments · May be fixed by #6401
Assignees
Labels
bug Something isn't working degraded-ux UX is degraded

Comments

@eatyourgreens
Copy link
Contributor

eatyourgreens commented Aug 9, 2023

Package

lib-classifier

Describe the bug

Since #5082, daily classification counts are persisted across page visits in the same tab. While this fixed #5081, if you leave a project and go to another, in the same tab, your daily counts go with you.

To Reproduce

Steps to reproduce the behavior:

  1. Go to Gravity Spy and do a few quick classifications.
  2. Navigate to The Daily Minor Planet in the same tab.
  3. See that the Daily Classifications chart still shows your activity from Gravity Spy.

Expected behavior

I think project preferences should reset when you move between projects.

@eatyourgreens eatyourgreens added the bug Something isn't working label Aug 9, 2023
@eatyourgreens
Copy link
Contributor Author

NB. you can also reproduce this bug by opening a tab and leaving it for a week while you, for example, go to Evanston for a meeting. The stored user object will have stale data and won't reflect any recent classifications you've made in a different tab or window.

@Saicbmm
Copy link

Saicbmm commented Dec 26, 2023

I believe that this bug is related to method overloading (update subject sets is creating a copy of the subject set for those projects which are not having any link or relation) because even though the task and its answers are different (the inputs are different), it still contributes to the total daily classifications. However in this case it contributes to a different project's classifications as well.

@eatyourgreens
Copy link
Contributor Author

I believe that this bug is related to method overloading (update subject sets is creating a copy of the subject set for those projects which are not having any link or relation) because even though the task and its answers are different (the inputs are different), it still contributes to the total daily classifications. However in this case it contributes to a different project's classifications as well.

This is meaningless GPT nonsense.

@goplayoutside3 goplayoutside3 self-assigned this Oct 28, 2024
@goplayoutside3 goplayoutside3 linked a pull request Oct 29, 2024 that will close this issue
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working degraded-ux UX is degraded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants