Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring syntax04 in line with other methods #1321

Closed
mattias-p opened this issue Mar 4, 2024 · 1 comment · Fixed by #1322
Closed

Bring syntax04 in line with other methods #1321

mattias-p opened this issue Mar 4, 2024 · 1 comment · Fixed by #1322
Assignees
Milestone

Comments

@mattias-p
Copy link
Member

Today all test methods but syntax04 share the same interface. Syntax04 expects its caller to figure out all the nameservers of the zone to be tested and call it repeatedly with each nameserver name while everyone else just takes the name of the zone to be tested. Moreover this exception is not documented anywhere.

Today this works for Zonemaster::Engine::test_zone() and Zonemaster::Engine::test_module() because they call Zonemaster::Engine::Test::Syntax::all() which meets the special expectation of syntax04. But Zonemaster::Engine::test_method() doesn't do anything special for syntax04, so the responsibility is pushed onto the caller. A notable caller is Zonemaster CLI which also doesn't do anything special for syntax04 so the responsibility is pushed onto the user.

The determination of nameserver names for syntax04 should be moved from Zonemaster::Engine::Test::Syntax::all() into Zonemaster::Engine::Test::Syntax::syntax04().

@mattias-p mattias-p self-assigned this Mar 4, 2024
@mattias-p mattias-p added this to the v2024.1 milestone Mar 4, 2024
@tgreenx tgreenx linked a pull request Mar 11, 2024 that will close this issue
@mattias-p
Copy link
Member Author

Fixed by #1322.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant