Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DNSSEC11 incorrectly outputs DS11_UNDETERMINED_DS for undelegated test #1099

Closed
matsduf opened this issue Jul 20, 2022 · 1 comment · Fixed by #1101
Closed

DNSSEC11 incorrectly outputs DS11_UNDETERMINED_DS for undelegated test #1099

matsduf opened this issue Jul 20, 2022 · 1 comment · Fixed by #1101
Assignees
@tgreenx
Labels
T-Bug Type: Bug in software or error in test case description
Milestone
v2022.2

Comments

@matsduf
Copy link
Contributor

matsduf commented Jul 20, 2022 •
edited
Loading

In test case DNSSEC11 it is specified that for undelegated test the parent zone is not to be queried for DS. If no DS data is provided in the input, the test case is to be terminated early without any messages. If DS data is provided it will be used for next part (checking the child zone).

The following messages, that belong to the test case, can never be outputted when an undelegated domain is tested per the test case specification.

  • DS11_INCONSISTENT_DS
  • DS11_UNDETERMINED_DS
  • DS11_PARENT_WITHOUT_DS
  • DS11_PARENT_WITH_DS

The implementation of the test case has an error. Here an undelegated test without DS has been run:

$ zonemaster-cli 190.187.193.in-addr.arpa --ns ns1.oxilion.nl --ns ns2.oxilion.nl --ns ns3.oxilion.net --raw --level info --test dnssec/dnssec11
   0.00 INFO      UNSPECIFIED    GLOBAL_VERSION   version=v4.5.1
   0.17 ERROR     DNSSEC11       DS11_UNDETERMINED_DS

This error was reported by @anandb-ripencc to the mailing list.
@matsduf matsduf added the T-Bug Type: Bug in software or error in test case description label Jul 20, 2022
@matsduf matsduf added this to the v2022.2 milestone Jul 20, 2022
@tgreenx tgreenx self-assigned this Jul 20, 2022
@matsduf matsduf mentioned this issue Jul 20, 2022
Closed
@tgreenx tgreenx mentioned this issue Jul 20, 2022
Merged
@tgreenx tgreenx linked a pull request Jul 20, 2022 that will close this issue
Add check for undelegated test in DNSSEC11 #1101
Merged
@matsduf
Copy link
Contributor Author

matsduf commented Jul 27, 2022

Resolved by #1101.

@matsduf matsduf closed this as completed Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tgreenx tgreenx

Labels
T-Bug Type: Bug in software or error in test case description
Projects
None yet
Milestone
v2022.2
Development

Successfully merging a pull request may close this issue.

Add check for undelegated test in DNSSEC11 tgreenx/zonemaster-engine
2 participants
@matsduf @tgreenx