From ff68fa6313f161b8dde17e4f2a2fc5304df2e883 Mon Sep 17 00:00:00 2001 From: Denis Pushkarev Date: Wed, 20 Dec 2023 05:27:20 +0700 Subject: [PATCH] drop `array-slice-simple` since in all current cases of usage it can't take `Array` subclasses --- packages/core-js/internals/array-buffer.js | 2 +- .../core-js/internals/array-slice-simple.js | 18 ------------------ .../object-get-own-property-names-external.js | 2 +- packages/core-js/modules/es.string.split.js | 2 +- .../core-js/modules/esnext.string.dedent.js | 2 +- .../core-js/modules/web.url.constructor.js | 2 +- 6 files changed, 5 insertions(+), 23 deletions(-) delete mode 100644 packages/core-js/internals/array-slice-simple.js diff --git a/packages/core-js/internals/array-buffer.js b/packages/core-js/internals/array-buffer.js index 499b58bb713c..6e524def71ad 100644 --- a/packages/core-js/internals/array-buffer.js +++ b/packages/core-js/internals/array-buffer.js @@ -17,7 +17,7 @@ var IEEE754 = require('../internals/ieee754'); var getPrototypeOf = require('../internals/object-get-prototype-of'); var setPrototypeOf = require('../internals/object-set-prototype-of'); var arrayFill = require('../internals/array-fill'); -var arraySlice = require('../internals/array-slice-simple'); +var arraySlice = require('../internals/array-slice'); var copyConstructorProperties = require('../internals/copy-constructor-properties'); var setToStringTag = require('../internals/set-to-string-tag'); var InternalStateModule = require('../internals/internal-state'); diff --git a/packages/core-js/internals/array-slice-simple.js b/packages/core-js/internals/array-slice-simple.js deleted file mode 100644 index b982dc22341e..000000000000 --- a/packages/core-js/internals/array-slice-simple.js +++ /dev/null @@ -1,18 +0,0 @@ -'use strict'; -var toAbsoluteIndex = require('../internals/to-absolute-index'); -var lengthOfArrayLike = require('../internals/length-of-array-like'); -var createProperty = require('../internals/create-property'); - -var $Array = Array; -var max = Math.max; - -module.exports = function (O, start, end) { - var length = lengthOfArrayLike(O); - var k = toAbsoluteIndex(start, length); - var fin = toAbsoluteIndex(end === undefined ? length : end, length); - var result = $Array(max(fin - k, 0)); - var n = 0; - for (; k < fin; k++, n++) createProperty(result, n, O[k]); - result.length = n; - return result; -}; diff --git a/packages/core-js/internals/object-get-own-property-names-external.js b/packages/core-js/internals/object-get-own-property-names-external.js index d0187ee25992..9bafd9a06160 100644 --- a/packages/core-js/internals/object-get-own-property-names-external.js +++ b/packages/core-js/internals/object-get-own-property-names-external.js @@ -3,7 +3,7 @@ var classof = require('../internals/classof-raw'); var toIndexedObject = require('../internals/to-indexed-object'); var $getOwnPropertyNames = require('../internals/object-get-own-property-names').f; -var arraySlice = require('../internals/array-slice-simple'); +var arraySlice = require('../internals/array-slice'); var windowNames = typeof window == 'object' && window && Object.getOwnPropertyNames ? Object.getOwnPropertyNames(window) : []; diff --git a/packages/core-js/modules/es.string.split.js b/packages/core-js/modules/es.string.split.js index 3c2a9142551d..11a434ae3f99 100644 --- a/packages/core-js/modules/es.string.split.js +++ b/packages/core-js/modules/es.string.split.js @@ -12,7 +12,7 @@ var advanceStringIndex = require('../internals/advance-string-index'); var toLength = require('../internals/to-length'); var toString = require('../internals/to-string'); var getMethod = require('../internals/get-method'); -var arraySlice = require('../internals/array-slice-simple'); +var arraySlice = require('../internals/array-slice'); var callRegExpExec = require('../internals/regexp-exec-abstract'); var regexpExec = require('../internals/regexp-exec'); var stickyHelpers = require('../internals/regexp-sticky-helpers'); diff --git a/packages/core-js/modules/esnext.string.dedent.js b/packages/core-js/modules/esnext.string.dedent.js index eb8f69b27fe8..4fbb8b513877 100644 --- a/packages/core-js/modules/esnext.string.dedent.js +++ b/packages/core-js/modules/esnext.string.dedent.js @@ -9,7 +9,7 @@ var toObject = require('../internals/to-object'); var isCallable = require('../internals/is-callable'); var lengthOfArrayLike = require('../internals/length-of-array-like'); var defineProperty = require('../internals/object-define-property').f; -var createArrayFromList = require('../internals/array-slice-simple'); +var createArrayFromList = require('../internals/array-slice'); var WeakMapHelpers = require('../internals/weak-map-helpers'); var cooked = require('../internals/string-cooked'); var parse = require('../internals/string-parse'); diff --git a/packages/core-js/modules/web.url.constructor.js b/packages/core-js/modules/web.url.constructor.js index 13f9b1238ca7..936257a3fdff 100644 --- a/packages/core-js/modules/web.url.constructor.js +++ b/packages/core-js/modules/web.url.constructor.js @@ -13,7 +13,7 @@ var anInstance = require('../internals/an-instance'); var hasOwn = require('../internals/has-own-property'); var assign = require('../internals/object-assign'); var arrayFrom = require('../internals/array-from'); -var arraySlice = require('../internals/array-slice-simple'); +var arraySlice = require('../internals/array-slice'); var codeAt = require('../internals/string-multibyte').codeAt; var toASCII = require('../internals/string-punycode-to-ascii'); var $toString = require('../internals/to-string');