fix: don't mutate shield options

zkochan · May 16, 2016 · a6567cc · a6567cc
1 parent 0e5c1bb
commit a6567cc
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/index.js b/index.js
@@ -18,11 +18,9 @@ function shieldman (service, opts) {
     return undefined
   }
 
-  if (!shieldTemplate.hasBranchVersion) {
-    delete opts.branch
-  }
+  const branch = shieldTemplate.hasBranchVersion ? opts.branch : null
 
-  const linkTemplate = opts.branch && shieldTemplate.branchLink || shieldTemplate.link
+  const linkTemplate = branch && shieldTemplate.branchLink || shieldTemplate.link
 
   return {
     text: shieldTemplate.text,
@@ -31,7 +29,7 @@ function shieldman (service, opts) {
   }
 
   function getShieldImage (imagePath) {
-    const branchSuffix = opts.branch && ('/' + opts.branch) || ''
+    const branchSuffix = branch && ('/' + branch) || ''
     return `https://img.shields.io/${format(imagePath, opts)}` +
       `${branchSuffix}.${ext}${opts.style ? `?style=${opts.style}` : ''}`
   }