New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wrong socks5h handling #57

Open

wenq1 opened this issue Jan 30, 2022 · 1 comment

wenq1 commented Jan 30, 2022

    let lookup = false;
    switch (this.proxy.protocol) {
      case 'socks4:':
      case 'socks5h:':      // this line is wrong,  should be 'socks5:' instead
        lookup = true;
        break;
    }

See urllib3/urllib3#1035,
Quote: In a proxy string, socks5h:// and socks4a:// mean that the hostname is
resolved by the SOCKS server, not the client

The text was updated successfully, but these errors were encountered:

Author

wenq1 commented May 6, 2022

Since you have already changed code, can you do a release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment