Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot rely on JDK8 Duration.parse #214

Closed
jdegoes opened this issue Mar 16, 2021 · 2 comments · Fixed by #276
Closed

Cannot rely on JDK8 Duration.parse #214

jdegoes opened this issue Mar 16, 2021 · 2 comments · Fixed by #276
Assignees
@calvinlfer
Labels
bug Something isn't working

Comments

@jdegoes
Copy link
Member

jdegoes commented Mar 16, 2021

Due to a bug, we may not rely on this method for parsing durations from strings, and should manually implement a workaround.
@jdegoes jdegoes added the bug Something isn't working label Mar 16, 2021
@jdegoes jdegoes mentioned this issue Mar 16, 2021
Merged
@plokhotnyuk
Copy link
Contributor

There is yet another bug (for ZonedDateTime.parse) that was fixed but not back ported to JDK 8. It affects parsed ZoneOffset around DST fall transition.

@calvinlfer
Copy link
Member

I will take this please 😸

This was referenced Apr 28, 2021
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@calvinlfer calvinlfer

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Avoid using Duration.parse directly due to JDK8 bug calvinlfer/zio-json
3 participants
@jdegoes @plokhotnyuk @calvinlfer