Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Routing / FC] Review / improve / finish the new AbstractController #1791

Closed
3 tasks
cmfcmf opened this issue Jun 19, 2014 · 3 comments
Closed
3 tasks

[Routing / FC] Review / improve / finish the new AbstractController #1791

cmfcmf opened this issue Jun 19, 2014 · 3 comments
Milestone

Comments

@cmfcmf
Copy link
Contributor

cmfcmf commented Jun 19, 2014

  • Add something like

    if ($controller instanceof TranslatableInterface) {
        $controller->setDomain(strtolower($bundle->getName());
    }

    to the Controller Resolver.

    The newer AbstractController is just a POC by the way, and there maybe better ways in general, like adding interfaces and letting the controller resolver so things according to that - e.g. TranslatableInterface implements setDomain() and let the controller resolver handler it.
    -- @Drak

  • ...

  • ?

refs #1552.

@cmfcmf cmfcmf added this to the 1.4.0 milestone Jun 19, 2014
@cmfcmf
Copy link
Contributor Author

cmfcmf commented Jun 20, 2014

This bundle might be helpful: http://jmsyst.com/bundles/JMSDiExtraBundle. It makes it possible to inject all kinds of to controllers services via annotations: http://jmsyst.com/bundles/JMSDiExtraBundle/master/usage. Not sure if this is what we want though 😏

@cmfcmf cmfcmf added the Routing label Aug 3, 2014
@Guite Guite unassigned cmfcmf Oct 4, 2014
@Guite Guite modified the milestones: 1.4.0, 1.4.1 Jan 31, 2015
@craigh
Copy link
Member

craigh commented Nov 11, 2015

@cmfcmf I wonder if your first point in this ticket is resolved here

https://github.com/zikula/core/blob/1.4/src/lib/Zikula/Core/Controller/AbstractController.php#L42-L43

@craigh craigh modified the milestones: 1.4.1, 1.4.2 Nov 23, 2015
@cmfcmf
Copy link
Contributor Author

cmfcmf commented Nov 28, 2015

Closing this meta issue.

@cmfcmf cmfcmf closed this as completed Nov 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants