fix(cc): preprocessor doesn't emit bin #20740
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhylmzr
force-pushed
the
master
branch
2 times, most recently
from
a48afe0
to
cc9d19b
Compare
dasimmet
approved these changes
Jul 23, 2024
alexrp
approved these changes
Aug 9, 2024
|
Can we get this merged, please? |
Vexu
approved these changes
Aug 26, 2024
src/main.zig
Outdated
| // otherwise our atomic rename into place will fail. This also | ||
| // makes Zig do less work, avoiding pointless file system operations. | ||
| if (mem.eql(u8, it.only_arg, "/dev/null")) { | ||
| if (mem.eql(u8, it.only_arg, "/dev/null") or mem.eql(u8, it.only_arg, "-")) { |
There was a problem hiding this comment.
This makes zig cc a.c -o - behave differently from clang/gcc which will output to a file named - but I guess it's an improvement over the current behavior of writing the binary file to stdout.
There was a problem hiding this comment.
I have adjusted the logic for emit binary files, now the behavior of zig cc a.c -o - is consistent with clang.
Vexu
approved these changes
Aug 27, 2024
src/main.zig
Outdated
| @@ -2518,7 +2518,7 @@ fn buildOutputType( | |||
| switch (c_out_mode orelse .link) { | |||
| .link => { | |||
| create_module.opts.output_mode = if (is_shared_lib) .Lib else .Exe; | |||
| emit_bin = if (out_path) |p| .{ .yes = p } else EmitBin.yes_a_out; | |||
| emit_bin = if (out_path) |p| .{ .yes = p } else emit_bin; | |||
There was a problem hiding this comment.
yes_a_out looks unused after this and could be deleted.
There was a problem hiding this comment.
Ah I was on the wrong branch and was getting the old behavior.
Why was this changed?
andrewrk
requested changes
Aug 27, 2024
|
fixed, sorry for missing this test case. |
clang's behavior. 1. `zig cc main.c -o /dev/null` shouldn't emit a.out 2. `zig cc -E main.c` and `zig cc -E main -o -` should output to stdout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zig cc main.c -o /dev/nullemita.out,zig cc -E main.cemitmain.o, this pr modifies the linking and preprocessing generation logic to be more consistent with clang's behavior.When using
clang -E main.corclang -E main.c -o -outputs directly to standard output, if usingclang -E main.c -o ait outputs to a file.Fix the following issues:
fixed: #20739
fixed: #20689
fixed: #20359
fixed: #20709