Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

std.tar: implement executable_bit_only mode #17462

Closed
andrewrk opened this issue Oct 9, 2023 · 1 comment · Fixed by #19504
Closed

std.tar: implement executable_bit_only mode #17462

andrewrk opened this issue Oct 9, 2023 · 1 comment · Fixed by #19504
Labels
bug Observed behavior contradicts documented or intended behavior contributor friendly This issue is limited in scope and/or knowledge of Zig internals. enhancement Solving this issue will likely involve adding new logic or components to the codebase. standard library This issue involves writing Zig code for the standard library.
Milestone

Comments

@andrewrk
Copy link
Member

andrewrk commented Oct 9, 2023

zig/lib/std/tar.zig

Lines 180 to 187 in 3a47bc7

.executable_bit_only => {
// This code does not look at the mode bits yet. To implement this feature,
// the implementation must be adjusted to look at the mode, and check the
// user executable bit, then call fchmod on newly created files when
// the executable bit is supposed to be set.
// It also needs to properly deal with ACLs on Windows.
@panic("TODO: unimplemented: tar ModeMode.executable_bit_only");
},

Related:

@andrewrk andrewrk added bug Observed behavior contradicts documented or intended behavior enhancement Solving this issue will likely involve adding new logic or components to the codebase. contributor friendly This issue is limited in scope and/or knowledge of Zig internals. standard library This issue involves writing Zig code for the standard library. os-windows labels Oct 9, 2023
@andrewrk andrewrk added this to the 0.13.0 milestone Oct 9, 2023
@andrewrk
Copy link
Member Author

andrewrk commented Mar 14, 2024

The idea of doing anything on Windows with the executable bit in pipeToFileSystem can be a separate issue. This can be closed if there is added an option that is defined to honor the executable bit on posix systems and do nothing on Windows systems.

This is also a low priority issue now because of the plan outlined here: #17463 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Observed behavior contradicts documented or intended behavior contributor friendly This issue is limited in scope and/or knowledge of Zig internals. enhancement Solving this issue will likely involve adding new logic or components to the codebase. standard library This issue involves writing Zig code for the standard library.
Projects
None yet
1 participant