Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get Ghostty on the Zig Package Manager #16672

Closed
4 of 6 tasks
Tracked by #17144
mitchellh opened this issue Aug 4, 2023 · 6 comments
Closed
4 of 6 tasks
Tracked by #17144

Get Ghostty on the Zig Package Manager #16672

mitchellh opened this issue Aug 4, 2023 · 6 comments
Labels
use case Describes a real use case that is difficult or impossible, but does not propose a solution.
Milestone

Comments

@mitchellh
Copy link
Sponsor Contributor

mitchellh commented Aug 4, 2023

Zig Version

0.11.0-dev.4404+4f6013bf5

Steps to Reproduce and Observed Behavior

You can close this if you want. I thought it might be useful to have a tracking issue of the issues that have blocked me from getting my terminal emulator using the Zig package manager in 0.11. It might be a good target for 0.11.1 (I mean, I'd love that).

I've just completed getting as far as I can. The good news is its... pretty close? Ghostty has dozens of dependencies with multiple layers of transitive shared dependencies so its a good stress test. I'm impressed I got as far as I did. And I'm very sorry I didn't do more testing before 0.11.0 (congrats!).

Update 10/1/2023: Ghostty is now able to use the package manager as of 0.12.0-dev.694+937e8cb70! See the comment for more information. This list now has additional issues we've run into but have found workarounds.

Full Blockers

These are actively preventing me from being able to use the package manager.

Major Issues

These are issues that have really nasty workarounds and that I hit very regularly.

Minor

These are issues that are easy to work around but just muck up the experience.

The Zig core team should all have access to Ghostty's source. If you don't have access let me know. Happy to provide any more details on Discord.

Expected Behavior

Down with all Git submodules.

@mitchellh mitchellh added the bug Observed behavior contradicts documented or intended behavior label Aug 4, 2023
@andrewrk andrewrk added this to the 0.12.0 milestone Aug 5, 2023
@andrewrk andrewrk added use case Describes a real use case that is difficult or impossible, but does not propose a solution. and removed bug Observed behavior contradicts documented or intended behavior labels Sep 29, 2023
@mitchellh
Copy link
Sponsor Contributor Author

Update, as of https://github.com/mitchellh/ghostty/pull/603 (for those who have access to the repo), Ghostty is now able to use the package manager with 0.12.0-dev.694+937e8cb70!

We can't remove all of our git submodules yet due to #16678. And even once that is fixed, we're starting to work on Windows so we'll need #14597 so that deps with symlinks are skipped on Windows.

This can potentially be closed now unless you want to keep this open until we have a workaround-free setup @andrewrk.

@andrewrk
Copy link
Member

andrewrk commented Oct 2, 2023

I'm happy to keep this open if there is a checkbox with an issue number for every workaround in your setup

@mitchellh
Copy link
Sponsor Contributor Author

Got it, the root comment is up to date on all the issues, with checkboxes.

@mitchellh
Copy link
Sponsor Contributor Author

Update: Ghostty no longer has to special-case tar files with symlinks, including the macOS SDK!

The only issue now is that on Windows we want to filter out unused dependencies. This issue is tracked as a checkbox item in the root issue.

@mitchellh
Copy link
Sponsor Contributor Author

Added #17472. We've had the Zig package manager in "production" for only a week and I find myself having to restart failed jobs a few times per day. So far all of these failed jobs have been temporary network issues, not the result of real outages.

@andrewrk
Copy link
Member

andrewrk commented Jan 9, 2024

This issue was useful while figuring out what issues to include in the 0.12.0 milestone. Now that the release is approaching, I'm going to close this and declare it a success. All the follow-up issues are tracked and assigned appropriate milestones.

@andrewrk andrewrk closed this as completed Jan 9, 2024
@ziglang ziglang deleted a comment from arsalanmohseni Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
use case Describes a real use case that is difficult or impossible, but does not propose a solution.
Projects
None yet
Development

No branches or pull requests

2 participants