function signature mistake

[vkensou]

In SDL_video.h, SDL_GetWindowPosition and SDL_GetWindowSize do not have a return value.

zsdl/src/sdl2.zig

Line 238 in 991c071

extern fn SDL_GetWindowPosition(window: *Window, x: ?*i32, y: ?*i32) i32;

zsdl/src/sdl2.zig

Line 244 in 991c071

extern fn SDL_GetWindowSize(window: *Window, w: ?*i32, h: ?*i32) i32;

[hazeycode]

These functions write to the pointers that are passed in if non-null. This reflects the underlying API.

The arguments should perhaps be renamed to out_w and out_h to help make this more obvious to the reader. Furthermore doc comments should be added to describe the API.

[vkensou]

These functions write to the pointers that are passed in if non-null. This reflects the underlying API.

The arguments should perhaps be renamed to out_w and out_h to help make this more obvious to the reader. Furthermore doc comments should be added to describe the API.

I mean, is the prebuilt SDL2.so/dll provided by gamedev modified? These two functions in SDL2 have no return value.
I am a bit confused. It seems the prebuilt SDL2.dll provided is actually SDL3.

[hazeycode]

Sorry, misunderstood the OP. You are correct, we are incorrectly defining the SDL procs as returning ints (as if they return an error code) but these should be void functions.

SDL3 does return values for these fns if there was an error. We probably mistakenly brought that change into our SDL2 bindings at some point.