Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

侧边栏的链接修改顺序页面刷新后无效 #14

Closed
tgly307 opened this issue Jul 26, 2018 · 3 comments
Closed

侧边栏的链接修改顺序页面刷新后无效 #14

tgly307 opened this issue Jul 26, 2018 · 3 comments
Labels
🐞bug Something isn't working

Comments

@tgly307
Copy link
Contributor

tgly307 commented Jul 26, 2018

侧边栏的链接有时需要调整顺序，但是打开新页面或者刷新后仍然按照添加顺序显示，调整效果未生效。
@tgly307
Copy link
Contributor Author

tgly307 commented Jul 26, 2018

看了一下代码，拖拽以后触发的updateBookmarks事件只是把结果保存到了store的bookmarks中，并没有存储到storage里，所以刷新重新读取就失效了。感觉应该是这个原因。

@tgly307
Copy link
Contributor Author

tgly307 commented Jul 27, 2018

#18 提交了PR

@zhuowenli zhuowenli added the 🐞bug Something isn't working label Aug 1, 2018
@zhuowenli
Copy link
Owner

感谢反馈，已合并代码。下个版本生效~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐞bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zhuowenli @tgly307