Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Report: Surface Normal Calculation is Wrong #10

Open
aj96 opened this issue Aug 14, 2019 · 0 comments
Open

Bug Report: Surface Normal Calculation is Wrong #10

aj96 opened this issue Aug 14, 2019 · 0 comments

Comments

@aj96
Copy link

aj96 commented Aug 14, 2019

In depth2normal_tf.py, line 121, you do normal_vector = normalize_l2(normals0). Your final normal vector should be some weighted average of the four resulting cross products normalized by l2 norm, right? line 121 should be
normal_vector = normalize_l2(normal_vector).

Also, isn't it kind of redundant to normalize these vectors multiple times? You should only need to normalize at the end?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant