Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade tests: allow to add gateway upgrade instructions during the test #2921

Closed
lumtis opened this issue Sep 25, 2024 · 0 comments · Fixed by #2932
Closed

Upgrade tests: allow to add gateway upgrade instructions during the test #2921

lumtis opened this issue Sep 25, 2024 · 0 comments · Fixed by #2932
Assignees
Labels
E2E E2E tests related

Comments

@lumtis
Copy link
Member

lumtis commented Sep 25, 2024

Describe the Issue

In v2 contracts, we add the ability to upgrade the gateway contracts on ZEVM and connected chains.

It can happen protocol modifications like #2904 are based on the assumption that the gateway contract is upgraded.

In practice, inbounds, outbounds will fail after upgrade before the gateway is upgraded (we should consider adding a pausing step in the playbook).

In the upgrade tests, we should add somewhere a place to specify instruction of upgrading the gateway contract.

Solution envisaged

Adding a method UpgradeGateways, this method is called in the upgrade test.
In this method, when upgrade is necessary, the gateway contract on EVM or ZEVM is redeploy with version currently defined in go.mod, and upgrade with the new implementation contract.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E2E E2E tests related
Projects
None yet
1 participant