Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added performance test is a bit sketchy #63

Closed
derrabauke opened this issue Jun 29, 2023 · 2 comments
Closed

Added performance test is a bit sketchy #63

derrabauke opened this issue Jun 29, 2023 · 2 comments

Comments

@derrabauke
Copy link

Hey folks! Thanks for the cool addon and the latest refactoring! 👏

One minor thing came to my mind when I had a look at the currently failig CI:

I think the added performance test is not very meaningful, since you are also testing "how fast can we produce 10.000 array entries". Shouldn't we measure only the time when render-begin to render-end?

Further why add a minimum time for that test?

Cheers

@amk221
Copy link
Contributor

amk221 commented Jun 30, 2023

It's true it could be better, it's very approximate, but it does the job in catching this issue tracked-tools/tracked-built-ins#405, which was all I really wanted.

@derrabauke
Copy link
Author

Alright, thanks for the clarification. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants