Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

# Release 4.3.3? #3779

Open
mloy opened this issue Jan 17, 2020 · 21 comments
Open

# Release 4.3.3? #3779

mloy opened this issue Jan 17, 2020 · 21 comments
Labels

Comments

@mloy
Copy link

mloy commented Jan 17, 2020

I'd like to ask whether there will be a release soon? We would like to use communication via websocket, which is available on master.

Regards,
Matthias

@brettviren
Copy link
Contributor

+1

I mentioned it in IRC but to put it here, I hope CLIENT/SERVER can leave draft in the next release. There were three open issues with the CLIENT/SERVER label. One just got closed and there are two more still open. Here's my amateur analysis:

#3248 appears blocked by a philosophical issue. @somdoron, in IRC it was suggested that you might weigh in on this. As I understand it, current sockets, including CLIENT will accept a message even if not yet connected. This behavior is counter to statements in the RFC. Non-draft sockets should not be changed as user code likely relies on this behavior. The choice then, as I see it: keep CLIENT as-is (behavior consistent with other socket types) or modify CLIENT to match RFC. If the first option is acceptable this issue could be closed. Otherwise, CLIENT needs to stay in draft until made RFC-compliant. FWIW, I prefer the former (ok as-is).

#2941 also needs a @somdoron mention. As I understand the issue, a feature must be added to expose the FD in order to allow thread-safe sockets to participate in FD-based event loops. If left open, does this issue need to block moving CLIENT/SERVER out of draft status?

@somdoron
Copy link
Member

I will take a look tomorrow. @brettviren are you coming to zeromq hackathon in the beginning and of February? We can work on those issues

@somdoron
Copy link
Member

@mloy I will try to finalize the WebSocket transport during the hackathon. It is almost ready...

@bluca
Copy link
Member

bluca commented Jan 18, 2020

Before the draft sockets become stable, the poller interface needs to be stable too, otherwise they aren't really usable. There are more issues open with that, including a pending pull request. Also, they need to be documented in the RFC.

@brettviren
Copy link
Contributor

@somdoron I won't attend, but I'll try to help nonetheless. So far my exposure to libzmq internals is rather limited.

@mloy
Copy link
Author

mloy commented Jan 18, 2020

Thank you for the very promising answers!

After writing this issue I pulled the current master to run my program with the current version. Unfortunately websocket support does not work anymore.
Commit c711941 did something bad for my case. My test program uses a websocket without a path. This does not work anymore.

I made a small pull request (#3781) to fix the problem.

@somdoron
Copy link
Member

@mloy are you using jszmq on the client side?

@mloy
Copy link
Author

mloy commented Jan 18, 2020

@somdoron I'm going to write a tests. I did not use jszmq, I wrote a simple pub/sub program. It uses the same logic for several types of connection (websocket, tcp, ipc and inproc).

@bluca
Copy link
Member

bluca commented Jan 19, 2020

I compiled the changelog #3784

@mjvankampen
Copy link
Contributor

Any news on this? There are quite a few fixes (not features) that are well worth a release in my opinion.

@fndisme
Copy link

fndisme commented Apr 14, 2020

Have any news? Bug fixed or new feathers?

@taita2104
Copy link

Any news on this concern? It would be nice to have some fixes brought in and also CLIENT/SERVER would be a very welcome add to the library.

@honglei
Copy link

honglei commented May 22, 2020

Any new? how about ZMQ_ROUTER_NOTIFY?

@somdoron
Copy link
Member

Not sure about the version yet, but checkout ZMQ_HELLO_MSG & ZMQ_DISCONNECT_MSG

@honglei
Copy link

honglei commented May 23, 2020

@somdoron

  1. ZMQ_DISCONNECT_MSG is not worked for DEALER socket, and it is not available in libzmq4.3.2. Users that use dealer-router mode wanna know disconnection on both dealer side and router side.

  2. The last stable libzmq version released ten months ago. Pyzmq I used in pypi still builded with libzmq4.3.2. So, python users need to build themselves if want to use these new features, which is not easy .

zmq.zmq_version()
#'4.3.2'
zmq.__version__
#'19.0.1'

@somdoron
Copy link
Member

I can make ZMQ_DISCONNECT_MSG on dealer as well, we are working on the next release.

@honglei
Copy link

honglei commented Jun 3, 2020

Any news?

@TobiSchluter
Copy link

How's it going with the release? Is it time for a maintenance release model where releases will be cut whether new features are included or not? I've been holding some development, waiting for a release that includes my pull request [1] for a year now and I see that at least one zmq project is working around the issue that it fixed [2], so a new release may reduce your maintenance burden as well ☺️

[1] #3681
[2] zeromq/cppzmq#391 (comment)

@honglei
Copy link

honglei commented Sep 3, 2020

It's really a bad idea for not release any maintenace version for more than one year. This issue has been opened nearly 9 months. People should reconsider whether it is still a good idea of using libzmq in products.

@TobiSchluter
Copy link

Yay, 4.3.3 was released. The oldest bug is no longer #110 but #989. So I would say that's a lot of progress 👍

@stale
Copy link

stale bot commented Apr 16, 2022

This issue has been automatically marked as stale because it has not had activity for 365 days. It will be closed if no further activity occurs within 56 days. Thank you for your contributions.

@stale stale bot added the stale label Apr 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

9 participants