Skip to content
This repository has been archived by the owner on May 22, 2024. It is now read-only.

farm#422 title declared in agenda.xsd #331

Merged
merged 13 commits into from
Mar 30, 2018
Merged

Conversation

amihaiemil
Copy link
Contributor

PR for zerocracy/farm#422, added the title in the xsd + modified .xml tests and agenda.xsl

@0crat 0crat added the scope label Mar 17, 2018
@0crat
Copy link
Collaborator

0crat commented Mar 17, 2018

Job #331 is now in scope, role is REV

@0crat
Copy link
Collaborator

0crat commented Mar 17, 2018

This pull request #331 is assigned to @carlosmiranda/z, here is why. The budget is 15 minutes, see §4. Please, read §27 and when you decide to accept the changes, inform @yegor256/z (the architect) right in this ticket. If you decide that this PR should not be accepted ever, also inform the architect.

Copy link
Contributor

@carlosmiranda carlosmiranda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amihaiemil see comment

SOFTWARE.
-->
<agenda version="0.25" updated="2016-12-29T09:03:21.684Z">
<order job="gh:test/test#1">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amihaiemil Qulice is complaining about the formatting of this XML.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amihaiemil could be the indentation. Our other XMLs use 2 space indentation.

@amihaiemil
Copy link
Contributor Author

@carlosmiranda I'm not sure what's wrong -- the fact that the line endings are \n?

@amihaiemil
Copy link
Contributor Author

amihaiemil commented Mar 19, 2018

@carlosmiranda anyway, I got another question, how do we continue with the puzzle tree? Yegor suggested how we should continue here but I am not sure where to leave the puzzle for that, I cannot leave it in this repo, or? I was thinking whether I should make another PR in /farm but it seems useless, it's cheaper and faster for the project if someone opens an Issue instead.

@carlosmiranda
Copy link
Contributor

@amihaiemil leave it in farm, if that's where the next step is relevant.

@amihaiemil
Copy link
Contributor Author

@carlosmiranda qulice fixed now, thanks

@amihaiemil amihaiemil changed the title farm#422 Title in agenda farm#422 title declared in agenda.xsd Mar 19, 2018
@carlosmiranda
Copy link
Contributor

@yegor256 looks good to merge here

@yegor256
Copy link
Owner

@amihaiemil why it's an attribute? XML attributes are used for meta-information, while XML elements -- for data. Make it <title> instead

@amihaiemil
Copy link
Contributor Author

@yegor256 done; can you have a look?

@amihaiemil
Copy link
Contributor Author

@yegor256 Can we also merge this?

yegor256 added a commit that referenced this pull request Mar 20, 2018
@yegor256
Copy link
Owner

@amihaiemil the changes you are introducing will crash all existing agenda's XML files, since they don't have <title> elements. They will become XSD non-conformant and the Farm will stop to work. In order to avoid that we have so-called "upgrades", which are XSL transformations that are modifying existing XML documents if their versions are too low. See: af69f8f

@amihaiemil
Copy link
Contributor Author

@yegor256 I see, I was also wondering about that... I'll have a look today

@amihaiemil
Copy link
Contributor Author

@yegor256 I added the upgrade and reversed the missing-title test, now we expect it to pass since the title is added by the upgrade.

@@ -21,6 +21,10 @@ SOFTWARE.
<xs:pattern value="none|gh:[A-Z0-9a-z.\-#/]{3,}"/>
</xs:restriction>
</xs:simpleType>
<xs:simpleType name="jobTitle">
<xs:restriction base="xs:string">
</xs:restriction>
Copy link
Owner

@yegor256 yegor256 Mar 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amihaiemil I think we should add some regexp here, at least .{3,}

@yegor256
Copy link
Owner

@amihaiemil the jobTitle type looks very non-restrictive. Let's add some rules there.

@amihaiemil
Copy link
Contributor Author

@yegor256 I was thinking about restirctions too, but then we would have to comply 1:1 with Github/Bitbucket/Jira etc. For instance, Github allows titles with only 1 character. Still think we should add our own rules?

@yegor256
Copy link
Owner

@amihaiemil yes, let's go with "at least one character" rule

@yegor256
Copy link
Owner

@rultor merge

@rultor
Copy link
Contributor

rultor commented Mar 29, 2018

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor
Copy link
Contributor

rultor commented Mar 29, 2018

@rultor merge

@amihaiemil @yegor256 Oops, I failed. You can see the full log here (spent 3min)

\u001b[32mInstalling powerpack 0.1.1\u001b[0m
\u001b[32mInstalling redcarpet 3.4.0 with native extensions\u001b[0m
\u001b[32mInstalling ruby-progressbar 1.9.0\u001b[0m
\u001b[32mInstalling unicode-display_width 1.3.0\u001b[0m
\u001b[32mInstalling slop 4.6.2\u001b[0m
Using bundler 1.11.2
\u001b[32mInstalling rainbow 2.2.2 with native extensions\u001b[0m
\u001b[32mInstalling parser 2.5.0.5\u001b[0m
Using nokogiri 1.8.2
\u001b[32mInstalling rubocop 0.48.1\u001b[0m
\u001b[32mInstalling xcop 0.5.7\u001b[0m
\u001b[32mInstalling rubocop-rspec 1.15.1\u001b[0m
\u001b[32mBundle complete! 8 Gemfile dependencies, 17 gems now installed.\u001b[0m
\u001b[32mUse `bundle show [gemname]` to see where a bundled gem is installed.\u001b[0m
+ rake
Checking XML files for XSD validity...
\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m
All 127 XML/XSD files are clean

Checking versions of XSL files...
Checking XML and XSL files...
\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m
All 32 XML/XSL files are clean

Running XSL tests...

All XSL tests passed

Testing auto-updates...
\u001b[32m.\u001b[0m
All auto-updates are clean

Running xcop...
Inspecting 252 files...
\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m
252 files checked, everything looks \u001b[32mpretty\u001b[0m
Running RuboCop...
Inspecting 2 files
\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m

2 files inspected, \u001b[32mno offenses\u001b[0m detected
grep -q -r '2016-2018'     --include '*.rb'     --include '*.xml'     --include '*.xsd'     --include '*.txt'     --include 'Rakefile'     .
+ mv /home/r/repo .
++ whoami
+ chown -R root repo
+ '[' -n '' ']'
++ whoami
+ sudo chown -R rultor repo
+ cd repo
+ git push origin master
To git@github.com:zerocracy/datum.git
 ! [rejected]        master -> master (fetch first)
error: failed to push some refs to 'git@github.com:zerocracy/datum.git'
hint: Updates were rejected because the remote contains work that you do
hint: not have locally. This is usually caused by another repository pushing
hint: to the same ref. You may want to first integrate the remote changes
hint: (e.g., 'git pull ...') before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details.
container 798acd4479afe3132cb95485d86ad0b07356028ddd0e8cebcff8265182c191ad is dead
Thu Mar 29 22:13:17 CEST 2018

@amihaiemil
Copy link
Contributor Author

@yegor256 I've synced the branch with master, can we try to merge again?

@yegor256
Copy link
Owner

@rultor merge

@rultor
Copy link
Contributor

rultor commented Mar 30, 2018

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit fc1ba17 into yegor256:master Mar 30, 2018
@rultor
Copy link
Contributor

rultor commented Mar 30, 2018

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 3min)

@0crat
Copy link
Collaborator

0crat commented Mar 30, 2018

@carlosmiranda/z this job was assigned to you 13days ago. It will be taken away from you soon, unless you close it, see §8. Read this and this, please.

@0crat
Copy link
Collaborator

0crat commented Mar 30, 2018

@carlosmiranda/z this job was assigned to you 13days ago. It will be taken away from you soon, unless you close it, see §8. Read this and this, please.

@carlosmiranda
Copy link
Contributor

@0crat status

@0crat
Copy link
Collaborator

0crat commented Apr 4, 2018

@0crat status (here)

@carlosmiranda This is what I know about this job, as in §32:

@carlosmiranda
Copy link
Contributor

@yegor256 can we take this out of scope, 0crat seems to be stuck on it

@yegor256
Copy link
Owner

yegor256 commented Apr 6, 2018

@0crat out

@0crat
Copy link
Collaborator

0crat commented Apr 6, 2018

@ypshenychka/z please review this job completed by @carlosmiranda/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

@0crat 0crat removed the scope label Apr 6, 2018
@0crat
Copy link
Collaborator

0crat commented Apr 6, 2018

@0crat out (here)

@yegor256 The job #331 is now out of scope

@0crat
Copy link
Collaborator

0crat commented Apr 6, 2018

Payment to ARC for a closed pull request, as in §28: +10 point(s) just awarded to @yegor256/z

@ypshenychka
Copy link

@carlosmiranda According to our QA Rules:

The code reviewer found at least three problems in the code.
Comments were mostly about design problems, not cosmetic issues.

Only one cosmetic issue was found during code review.
Please confirm that you'll try to find at least three major problems while future reviews.

@ypshenychka
Copy link

@amihaiemil According to our QA Rules:

All commit messages have links to issues.

Please confirm that you'll try to follow this rule next time.

@carlosmiranda
Copy link
Contributor

@ypshenychka confirmed

@amihaiemil
Copy link
Contributor Author

@ypshenychka I confirm :)

@ypshenychka
Copy link

@amihaiemil Thanks.

@ypshenychka
Copy link

@carlosmiranda Thank you.

@ypshenychka
Copy link

@0crat quality acceptable

@0crat
Copy link
Collaborator

0crat commented Apr 6, 2018

Order was finished, quality is "acceptable": +15 point(s) just awarded to @carlosmiranda/z

@0crat
Copy link
Collaborator

0crat commented Apr 6, 2018

Quality review completed: +8 point(s) just awarded to @ypshenychka/z

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants