-
Notifications
You must be signed in to change notification settings - Fork 11
Conversation
Job #331 is now in scope, role is |
This pull request #331 is assigned to @carlosmiranda/z, here is why. The budget is 15 minutes, see §4. Please, read §27 and when you decide to accept the changes, inform @yegor256/z (the architect) right in this ticket. If you decide that this PR should not be accepted ever, also inform the architect. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@amihaiemil see comment
xml/pmo/agenda/-missing-title.xml
Outdated
SOFTWARE. | ||
--> | ||
<agenda version="0.25" updated="2016-12-29T09:03:21.684Z"> | ||
<order job="gh:test/test#1"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@amihaiemil Qulice is complaining about the formatting of this XML.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@amihaiemil could be the indentation. Our other XMLs use 2 space indentation.
@carlosmiranda I'm not sure what's wrong -- the fact that the line endings are |
@carlosmiranda anyway, I got another question, how do we continue with the puzzle tree? Yegor suggested how we should continue here but I am not sure where to leave the puzzle for that, I cannot leave it in this repo, or? I was thinking whether I should make another PR in /farm but it seems useless, it's cheaper and faster for the project if someone opens an Issue instead. |
@amihaiemil leave it in farm, if that's where the next step is relevant. |
@carlosmiranda qulice fixed now, thanks |
@yegor256 looks good to merge here |
@amihaiemil why it's an attribute? XML attributes are used for meta-information, while XML elements -- for data. Make it |
@yegor256 done; can you have a look? |
@yegor256 Can we also merge this? |
@amihaiemil the changes you are introducing will crash all existing agenda's XML files, since they don't have |
@yegor256 I see, I was also wondering about that... I'll have a look today |
@yegor256 I added the upgrade and reversed the |
xsd/pm/scope/types.xsd
Outdated
@@ -21,6 +21,10 @@ SOFTWARE. | |||
<xs:pattern value="none|gh:[A-Z0-9a-z.\-#/]{3,}"/> | |||
</xs:restriction> | |||
</xs:simpleType> | |||
<xs:simpleType name="jobTitle"> | |||
<xs:restriction base="xs:string"> | |||
</xs:restriction> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@amihaiemil I think we should add some regexp here, at least .{3,}
@amihaiemil the |
@yegor256 I was thinking about restirctions too, but then we would have to comply 1:1 with Github/Bitbucket/Jira etc. For instance, Github allows titles with only 1 character. Still think we should add our own rules? |
@amihaiemil yes, let's go with "at least one character" rule |
@rultor merge |
@amihaiemil @yegor256 Oops, I failed. You can see the full log here (spent 3min)
|
@yegor256 I've synced the branch with master, can we try to merge again? |
@rultor merge |
@carlosmiranda/z this job was assigned to you 13days ago. It will be taken away from you soon, unless you close it, see §8. Read this and this, please. |
@carlosmiranda/z this job was assigned to you 13days ago. It will be taken away from you soon, unless you close it, see §8. Read this and this, please. |
@0crat status |
@carlosmiranda This is what I know about this job, as in §32:
|
@yegor256 can we take this out of scope, |
@0crat out |
@ypshenychka/z please review this job completed by @carlosmiranda/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed |
@carlosmiranda According to our QA Rules:
Only one cosmetic issue was found during code review. |
@amihaiemil According to our QA Rules:
Please confirm that you'll try to follow this rule next time. |
@ypshenychka confirmed |
@ypshenychka I confirm :) |
@amihaiemil Thanks. |
@carlosmiranda Thank you. |
@0crat quality acceptable |
Order was finished, quality is "acceptable": +15 point(s) just awarded to @carlosmiranda/z |
Quality review completed: +8 point(s) just awarded to @ypshenychka/z |
PR for zerocracy/farm#422, added the title in the xsd + modified
.xml
tests andagenda.xsl