Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish on PyPi #8

Open
efagerberg opened this issue May 9, 2021 · 4 comments
Open

Publish on PyPi #8

efagerberg opened this issue May 9, 2021 · 4 comments

Comments

@efagerberg
Copy link

Are there any plans to publish this to pypi?

@zero323
Copy link
Owner

zero323 commented Jul 2, 2021

Sorry for delayed response @efagerberg

As it is, it is hardly a finished project ‒ I started working on, hit some wall (mostly related to variadic generic if recall correctly, so it might be easy to address with new typing features) and got distracted. So I am not sure if it will be that useful in practice, but if there is interest in that, we might give it a shot.

I'd prefer to hear if @mrocklin has input before we proceed.

@mrocklin
Copy link

mrocklin commented Jul 2, 2021

cc @eriknw who shepherds Toolz these days.

My sense is that Toolz would be open to type annotations within the codebase today, if that would be easier than publishing stubs.

I am not surprised that some of the functions would be hard to type. But hopefully there is some good we can do here without being perfect.

@eriknw
Copy link

eriknw commented Jul 4, 2021

Thanks for the ping!

Indeed, I believe I and other would love to have type annotations that worked with mypy and typeguard in toolz directly, and this repo looks like a great start.

@Jiehong explored this here: pytoolz/toolz#502
and @twoertwein added some here: pytoolz/toolz#516

I don't know what the "best" approach or style would be for toolz, but I'm happy to give it a try and to have things added in a piecemeal fashion.

@zero323
Copy link
Owner

zero323 commented Jul 8, 2021

Thanks for your responses @mrocklin and @eriknw!

Indeed, I believe I and other would love to have type annotations that worked with mypy and typeguard in toolz directly, and this repo looks like a great start.

@eriknw That's great. I can try to synchronize this with the main repo once I have a spare moment, but if you, or any other contributor, wants to pick it from here, be my guess (just please ping me so I know that I can remove it from my TODO).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants