Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added italian translation #35

Merged
merged 3 commits into from
Oct 4, 2022
Merged

Added italian translation #35

merged 3 commits into from
Oct 4, 2022

Conversation

MattNot
Copy link
Contributor

@MattNot MattNot commented Oct 2, 2022

I translated "Omni" as "Universal", in Italian there isn't a real difference between the two terms as "omnia" is the latin for "everything". Let me know if is okay for you. Can you please add this repo to hacktoberfest? Ty.

closes #16

@zer0Kerbal
Copy link
Owner

closes #16

@zer0Kerbal zer0Kerbal added the type: localization related to localization and translations label Oct 3, 2022
@zer0Kerbal zer0Kerbal added this to the 1.0.1.0-release milestone Oct 3, 2022
@zer0Kerbal
Copy link
Owner

I translated "Omni" as "Universal", in Italian there isn't a real difference between the two terms as "omnia" is the latin for "everything". Let me know if is okay for you. Can you please add this repo to hacktoberfest? Ty.

closes #16

@MattNot either way would be fine - although Omnia might be better because of the addon's abbreviation is ROS.

hacktoberfest - I believe all I have to do it add hacktoberfest to the repo tags; if so that is done.

Thank you!

@zer0Kerbal zer0Kerbal changed the base branch from master to 1.0.1.0-release October 3, 2022 00:44
@zer0Kerbal zer0Kerbal self-requested a review October 3, 2022 00:45
@zer0Kerbal zer0Kerbal added the hacktoberfest-accepted flag for stating PR is accepted as appropriate for hacktoberfest label Oct 3, 2022
Copy link
Owner

@zer0Kerbal zer0Kerbal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hacktoberfest approved.

see two comments, will give chance to update if so choose, otherwise will merge.

Thank you!
zed'K

Signed-off-by: zer0Kerbal <39887717+zer0Kerbal@users.noreply.github.com>
@MattNot
Copy link
Contributor Author

MattNot commented Oct 3, 2022

Hi! Yeah, maybe leaving "Omnia" is better. I'll do this asap I'll return home from work. For hacktoberfest, the label should be just "hacktoberfest" (without "accepted") otherwise it won't count, thank you

@zer0Kerbal
Copy link
Owner

Hi! Yeah, maybe leaving "Omnia" is better. I'll do this asap I'll return home from work. For hacktoberfest, the label should be just "hacktoberfest" (without "accepted") otherwise it won't count, thank you

I want your contributions to be counted so I looked up https://hacktoberfest.com/participation/

I could be wrong so please confirm

HERE’S HOW WE VALIDATE CONTRIBUTOR PULL/MERGE REQUESTS (“PR/MRS”) FOR HACKTOBERFEST
...
YOUR PR/MRS MUST BE IN A REPO TAGGED WITH THE “HACKTOBERFEST” TOPIC, OR BE LABELED “HACKTOBERFEST-ACCEPTED.”
...

@zer0Kerbal zer0Kerbal added the hacktoberfest flag for entry into hacktoberfest label Oct 4, 2022
@MattNot
Copy link
Contributor Author

MattNot commented Oct 4, 2022

Changed the term, hacktoberfest is okay. Ty :-)

Copy link
Owner

@zer0Kerbal zer0Kerbal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@zer0Kerbal zer0Kerbal merged commit 3f8b62d into zer0Kerbal:1.0.1.0-release Oct 4, 2022
@zer0Kerbal
Copy link
Owner

Changed the term, hacktoberfest is okay. Ty :-)

thank you!

@MattNot MattNot deleted the italian-translation branch October 4, 2022 20:22
@zer0Kerbal zer0Kerbal modified the milestones: 1.0.1.0-release, 1.0.0.1-release Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest flag for entry into hacktoberfest hacktoberfest-accepted flag for stating PR is accepted as appropriate for hacktoberfest type: localization related to localization and translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Italian (Italiano) <it-it.cfg>
2 participants