Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why don't you add parsing function in component.json? #73

Closed
bugtype opened this issue May 26, 2020 · 2 comments · Fixed by #92
Closed

Why don't you add parsing function in component.json? #73

bugtype opened this issue May 26, 2020 · 2 comments · Fixed by #92
Assignees
Labels
enhancement New feature or request

Comments

@bugtype
Copy link

bugtype commented May 26, 2020

Thank you for continuing to add good features. I'd like to make a good suggestion.

component.json becomes too large if there are many components.

It seems good to add parsing-readable features such as jest and stroybook

// jest
  testRegex: ['.*\\.spec\\.(ts|tsx)$'],
// storybook
  stories: ['../src/**/*.stories.tsx'],

For example

.zeplin/ component.json

  zeplinComponent: ['../src/**/*.zeplin.json'],

components/ListItemText/zeplin.json

    {
      "path": "./ListItemText.tsx",
      "zeplinNames": [
        "Lists/Default/Default/Text",
        "Lists/Default/with Secondary/Text",
        "Lists/Default/with Caption/Text"
      ],
      "storybook": {
        "kind": "core/ListItemText",
        "stories": [
          "Lists/Default/Default/Text",
          "Lists/Default/with Secondary/Text",
          "Lists/Default/with Caption/Text"
        ]
      }
    }

Is this the right way to suggest it?
Should I post the issue on the zeplin-cli, not here?

@fonurr
Copy link
Contributor

fonurr commented May 27, 2020

Hey @bugtype this is a good suggestion that we are also considering. For now we have a live feature I might suggest you to take a look. It is wildcard support for component zeplinNames. For information see this document. It is not supported by our VS Code extension yet, but we are working on it.

@fonurr fonurr linked a pull request Jun 5, 2020 that will close this issue
@fonurr
Copy link
Contributor

fonurr commented Jun 5, 2020

#92 brings the wildcard support I mentioned in the previous comment. This is issue will be closed when it is merged, however the original suggestion by @bugtype is beyond vscode extension and will be discussed later by the whole connected components team.

@fonurr fonurr added the enhancement New feature or request label Jun 5, 2020
@fonurr fonurr self-assigned this Jun 5, 2020
@fonurr fonurr closed this as completed in #92 Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants