Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Receiving 404 on Storybook v6.1.0+ #39

Closed
yuqu opened this issue Mar 18, 2021 · 1 comment · Fixed by #40
Closed

Receiving 404 on Storybook v6.1.0+ #39

yuqu opened this issue Mar 18, 2021 · 1 comment · Fixed by #40

Comments

@yuqu
Copy link
Contributor

yuqu commented Mar 18, 2021

Projects using Storybook v6.1.0+ seems to be having problems when the plugin try to load Storybook into JSDOM.

Zeplin CLI - v1.1.6

Waiting Storybook to start…
Detected Storybook at http://localhost:6006/iframe.html

Connecting components to Zeplin components failed.

    404 - {"type":"Buffer","data":[60,33,68,79,67,84,89,80,69,32,104,116,109,108,62,10,60,104,116,109,108,32,108,97,110,103,61,34,101,110,34,62,10,60,104,101,97,100,62,10,60,109,101,116,97,32,99,104,97,114,115,101,116,61,34,117,116,102,45,56,34,62,10,60,116,105,116,108,101,62,69,114,114,111,114,60,47,116,105,116,108,101,62,10,60,47,104,101,97,100,62,10,60,98,111,100,121,62,10,60,112,114,101,62,67,97,110,110,111,116,32,71,69,84,32,47,105,102,114,97,109,101,46,104,116,109,108,60,47,112,114,101,62,10,60,47,98,111,100,121,62,10,60,47,104,116,109,108,62,10]}

Error is coming from JSDOM when it receive 404 from the started up instance. The buffer data is:

'<!DOCTYPE html>\n' +
  '<html lang="en">\n' +
  '<head>\n' +
  '<meta charset="utf-8">\n' +
  '<title>Error</title>\n' +
  '</head>\n' +
  '<body>\n' +
  '<pre>Cannot GET /iframe.html</pre>\n' +
  '</body>\n' +
  '</html>\n'

Workaround: Start the Storybook instance separately and then execute zeplin connect
@yuqu yuqu mentioned this issue Mar 25, 2021
Merged
@yuqu yuqu linked a pull request Mar 25, 2021 that will close this issue
Fix storybook startup issues #40
Merged
@yuqu
Copy link
Contributor Author

yuqu commented Apr 5, 2021

Fixed in #40

@yuqu yuqu closed this as completed Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix storybook startup issues zeplin/cli-connect-storybook-plugin
1 participant
@yuqu