Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retain Order of Domains #19

Closed
zenhack opened this issue Jan 3, 2017 · 5 comments
Closed

Retain Order of Domains #19

zenhack opened this issue Jan 3, 2017 · 5 comments

Comments

@zenhack
Copy link
Owner

zenhack commented Jan 3, 2017

Issue by zx2c4
Tuesday Feb 09, 2016 at 13:42 GMT
Originally opened as kuba/simp_le#72


For certificates that authenticate multiple sites, I'd like to specify which domain goes in the CN field. This should probably be the first -d domain specified. But since simp_le uses a dictionary, the ordering provided by the user is lost.

Could you have the ordering of -d be preserved, or add another switch to specify explicitly which domain should be in the CN?

Thanks.

@zenhack
Copy link
Owner Author

zenhack commented Jan 3, 2017

Comment by trunneml
Sunday Feb 21, 2016 at 16:42 GMT


It should be enough to change the dict in https://github.com/kuba/simp_le/blob/master/simp_le.py#L1273 to an OrderedDict.

@zenhack
Copy link
Owner Author

zenhack commented Jan 3, 2017

Comment by wiml
Sunday Feb 21, 2016 at 23:03 GMT


FWIW, if there is a domain name SAN, then the contents of the CN are (should be) ignored: this is mentioned in RFC2818 (section 3.1), and also in RFC6125 (section 6.4.4).

Also, I think the ordering of the entries in the SAN list is fixed by the DER encoding rules for SETs.

I think that, between those two things, it would make more sense to simply have an option to specify the contents of the CN, or perhaps the entire subject distinguished name. If you have web clients from the 1990s that require a hostname there, you can specify the one you like.

@zenhack
Copy link
Owner Author

zenhack commented Jan 3, 2017

Comment by zx2c4
Sunday Feb 21, 2016 at 23:06 GMT


Either way works well for me. I think I like the idea of having an explicit option the best though.

@zenhack
Copy link
Owner Author

zenhack commented Jan 3, 2017

Comment by kuba
Sunday Apr 17, 2016 at 21:23 GMT


This will be WONTFIX obsolete as of #105.

@zenhack
Copy link
Owner Author

zenhack commented Aug 31, 2017

Closing; see discussion in #30

@zenhack zenhack closed this as completed Aug 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant