-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retain Order of Domains #19
Comments
Comment by trunneml It should be enough to change the dict in https://github.com/kuba/simp_le/blob/master/simp_le.py#L1273 to an OrderedDict. |
Comment by wiml FWIW, if there is a domain name SAN, then the contents of the CN are (should be) ignored: this is mentioned in RFC2818 (section 3.1), and also in RFC6125 (section 6.4.4). Also, I think the ordering of the entries in the SAN list is fixed by the DER encoding rules for SETs. I think that, between those two things, it would make more sense to simply have an option to specify the contents of the CN, or perhaps the entire subject distinguished name. If you have web clients from the 1990s that require a hostname there, you can specify the one you like. |
Comment by zx2c4 Either way works well for me. I think I like the idea of having an explicit option the best though. |
Closing; see discussion in #30 |
Issue by zx2c4
Tuesday Feb 09, 2016 at 13:42 GMT
Originally opened as kuba/simp_le#72
For certificates that authenticate multiple sites, I'd like to specify which domain goes in the CN field. This should probably be the first
-d
domain specified. But since simp_le uses a dictionary, the ordering provided by the user is lost.Could you have the ordering of
-d
be preserved, or add another switch to specify explicitly which domain should be in the CN?Thanks.
The text was updated successfully, but these errors were encountered: