New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use jsonparse for ND-JSON instead of the custom made implementa… #493

Merged

knownasilya merged 1 commit into zemirco:master from juanjoDiaz:ndjson_with_jsonparse

Nov 2, 2020

Collaborator

juanjoDiaz commented Nov 1, 2020

JSON parse support ND-JSON perfectly. No reason to use custom implementation.

Also, my custom implementation is a lot weaker and might fail with escaped newlines and things like that.


          feat: use jsonparse for ND-JSON instead of the custom made implementa…

f6bfa50

…tion

coveralls commented Nov 1, 2020

Coverage remained the same at 100.0% when pulling f6bfa50 on juanjoDiaz:ndjson_with_jsonparse into 471f5a7 on zemirco:master.

knownasilya merged commit 55aa0c7 into zemirco:master

juanjoDiaz deleted the ndjson_with_jsonparse branch

November 2, 2020 07:05

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet