Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance improvements #360

Merged
merged 13 commits into from
Mar 10, 2019
Merged

Performance improvements #360

merged 13 commits into from
Mar 10, 2019

Conversation

juanjoDiaz
Copy link
Collaborator

Just a bunch of performance improvement and an important bugfix that made reusing the same parser to become increasingly slower.

Should help with #359 .

I'll submit tomorrow or so another PR with a new Async API to be able to use streams in the browser at easy.

@coveralls
Copy link

coveralls commented Feb 24, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling 6c979d9 on juanjoDiaz:performance_improvements into 58bd0ae on zemirco:master.

@juanjoDiaz
Copy link
Collaborator Author

Actually, I just pushed here the new API as well.
Comments are welcomed!

It's basically a convenient way to use the stream API.
Reason for it is that it's not soo straight forward to use the streams in the browser.

@knownasilya knownasilya self-requested a review February 25, 2019 01:01
@juanjoDiaz
Copy link
Collaborator Author

@knownasilya anything blocking for merging and releasing this?

@knownasilya
Copy link
Collaborator

Ah, sorry missed the change that fixed the test. We could probably start using the reviewer feature

@knownasilya knownasilya merged commit d59dea1 into zemirco:master Mar 10, 2019
@juanjoDiaz juanjoDiaz deleted the performance_improvements branch March 31, 2019 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants