Replace fields config by a global config #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knownasilya
added a commit
that referenced
this pull request
Aug 19, 2019
This reverts commit 6b2183b.
knownasilya
pushed a commit
that referenced
this pull request
Aug 19, 2019
BREAKING CHANGE: `--fields-config` option has been removed, use the new `--config` option for all configuration, not just fields.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change so we would need to move to json2csv 5.X.
But I think that's great to be able to pass the full config as a JSON file instead of having to pass a JSON for the files and other flags for other stuff.
No need to merge this and go to v5 immediately. Let's see if there are more breaking changes that would be good to add.