New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not properly escaping quotes with non default quote #300

Closed

furstenheim opened this issue May 23, 2018 · 1 comment

Labels

bug

furstenheim commented May 23, 2018

When using json from node (not the cli) if I change the quote symbol it does not get properly escaped. If the json is

const obj = [{a: "b'c"}]
new J2csvParser({fields: ['a'], delimitir: ';', quote: '''})

The output will be 'b'c' which is not correct. It should be escaped 'b''c'
Version of json2csv 4.1.2

juanjoDiaz added the bug label

juanjoDiaz mentioned this issue

Escape custom quotes correctly #301

Merged

knownasilya closed this as completed in #301

Collaborator

knownasilya commented May 23, 2018

Published as v4.1.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment