Fix double quote escaping before new line #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aj-r
reviewed
Mar 5, 2018
| @@ -181,7 +181,7 @@ class JSON2CSVBase { | |||
| //a backslash, and it's not at the end of the stringifiedValue. | |||
| stringifiedValue = stringifiedValue | |||
| .replace(/^"(.*)"$/, this.opts.quote + '$1' + this.opts.quote) | |||
| .replace(/(\\")(?=.)/g, this.opts.doubleQuote) | |||
| .replace(/(\\")(?!$)/g, this.opts.doubleQuote) | |||
There was a problem hiding this comment.
Assuming your tests pass, this fix is good with me. Although I thought $ would match both end of line and end of string. Or does it only match end of string?
There was a problem hiding this comment.
Looks like $ only matches line break if the multiline flag (m) is true (which it's not). So this looks good to me.
|
Published as v4.0.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the proper fix for the issues reported on #267 with a couple test to ensure that there is no regressions.